Add FactValue type #133
Merged
Add FactValue type #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
add_fact_value_sum_type
branch
from
fedd170
to
c71b642
Compare
fabriziosestito
requested review from
arbulu89,
CDimonaco and
rtorrero
and removed request for
arbulu89,
CDimonaco and
rtorrero
arbulu89
approved these changes
Nov 11, 2022
fabriziosestito
force-pushed
the
add_fact_value_sum_type
branch
from
cc8438d
to
b5dbf01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
FactValuevariant type and the possibility to return lists or maps from the gatherer.Using variant types with sealed interfaces is not the most idiomatic thing in golang, but the
structpbpackage from google uses the same trick to define the google protobuf value, and it saves us some runtime errors if the users returns types that we do not handle asinterface{}.The conversion to a protobuf message is straight forward by just using the
AsInterface()method.Existings gatehrers and plugins are refactored to comply with the new return type.
Also, I've added float and bool type and an utility function to parse a string to a number or a bool.