Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sapservices gatherer improvement #337

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Sapservices gatherer improvement #337

merged 3 commits into from
Jun 25, 2024

Conversation

CDimonaco
Copy link
Member

This PR enhance the sapservices gatherer

  • Fix a bug with mid-line comments in sapservices entry: The comments are now discarded
  • The instance number is extracted from sapservices entries in both scenarios

This PR changes the shape of the gatherer response, adds a new field instance_nr containing the instance number.

@CDimonaco CDimonaco added bug Something isn't working enhancement New feature or request go Pull requests that update Go code labels Jun 25, 2024
@CDimonaco CDimonaco requested a review from arbulu89 June 25, 2024 13:52
@CDimonaco CDimonaco self-assigned this Jun 25, 2024
@CDimonaco CDimonaco mentioned this pull request Jun 25, 2024
Merged
@CDimonaco CDimonaco force-pushed the sapservices_gatherer_improvement branch from 94ac4d9 to fa43179 Compare June 25, 2024 13:59
arbulu89
arbulu89 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
Could we have an additional test case where we have a comment after some of the entries?
After all, this was the main thing we wanted to fix.
PD: Don't forget to update the gatherer documentation in wanda

internal/factsengine/gatherers/sapservices.go Show resolved Hide resolved
internal/factsengine/gatherers/sapservices.go Outdated Show resolved Hide resolved
@CDimonaco CDimonaco merged commit 269792f into main Jun 25, 2024
9 checks passed
@CDimonaco CDimonaco deleted the sapservices_gatherer_improvement branch June 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

Assignees

@CDimonaco CDimonaco

Labels
bug Something isn't working enhancement New feature or request go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CDimonaco @arbulu89