Update regular expression #92
Conversation
Updating the regular expression for checks 1.1.2, 1.1.4, 1.1.5, 1.1.6, 1.1.7 and 1.1.8 in order to allow blank spaces before the colon.
|
@arbulu89 since you were the last one to work on this regular expression, I request that you review this change -please- before merging to main. I've tried to add you as reviewer but it looks like I'm not allowed. The reason for the change is to allow blank spaces before the colon. As it is right now, the checks fail when such spaces are found. Thank you! |
There was a problem hiding this comment.
@abravosuse Its fine from my side.
Where did you find this scenario? When the corosync.conf file is autogenerated we don't have such a spaces. Is it a "lab/testing" env? In this case, it should be as simple as testing the with this changes I guess
|
Thank you @arbulu89 . This scenario is part of the test kit developed by the Checks Team. For each check in the catalog, there is a number of test cases or scenarios that the kit stages before running the check. Adding blank spaces to entries in configuration files is one of them. |
Updating the regular expression for checks 1.1.2, 1.1.3, 1.1.4, 1.1.5, 1.1.6, 1.1.7 and 1.1.8 in order to allow blank spaces before the colon.