Updates to websql plugin and shim to use shim in Safari #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekseykulikov
added a commit
that referenced
this pull request
Dec 24, 2014
Updates to websql plugin and shim to use shim in Safari
|
Thanks a lot! It breaks reuse transaction tests, but I will fix them, because I'm going to rewrite this feature for #18 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very much a work in progress as the tests are still broken in Safari (and PhantomJS) primarily due to missing functionality in the shim (can't delete indexes, and IDBTransaction not implementing EventTarget or firing events).
The shim seems quite broken and doesn't look like the github project has had much love in the last few months (not to mention has a pile of open issues/PRs). I take it you're just copying in a dist ver of the shim? Is it ok to edit it like this or should I be opening pull requests against https://github.com/axemclion/IndexedDBShim?
Fixes #17.