Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSeek, useRaycaster and useLoader are missing from TresJS 3.8.0 #619

Closed
5 tasks done
bperel opened this issue Apr 4, 2024 · 4 comments · Fixed by #625
Closed
5 tasks done

useSeek, useRaycaster and useLoader are missing from TresJS 3.8.0 #619

bperel opened this issue Apr 4, 2024 · 4 comments · Fixed by #625
Assignees
Labels
bug Something isn't working p2-edge-case Bug, but has a workaround or limited in scope (priority) regression The issue only appears after a new release

Comments

@bperel
Copy link
Contributor

bperel commented Apr 4, 2024

Describe the bug

I am importing useSeek in my project:

import { useSeek } from "@tresjs/core";

Since the upgrade to Tres 3.8.0, I get the error Module ""@tresjs/core"" has no exported member "useSeek". Did you mean to use "import useSeek from "@tresjs/core"" instead?

Indeed, useSeek, useRaycaster and useLoader which are exported in src/composables/index.d.ts don't seem to be present in the package anymore.

Reproduction

https://www.runpkg.com/?@tresjs/core@3.8.0/dist/src/composables/index.d.ts

Steps to reproduce

Unfortunately I didn't manage to reproduce the issue on Stackblitz, but the link above shows that the 3 files are missing from the directory where it's supposed to be imported from.

System Info

No response

Used Package Manager

pnpm

Code of Conduct

@alvarosabu alvarosabu added regression The issue only appears after a new release bug Something isn't working p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority) labels Apr 8, 2024
@alvarosabu alvarosabu self-assigned this Apr 8, 2024
@alvarosabu
Copy link
Member

Hi @bperel thanks for raising this. Seems to be a typing issue because the composable are indeed correctly exported in the package

Screenshot 2024-04-08 at 10 33 42

@alvarosabu alvarosabu added p2-edge-case Bug, but has a workaround or limited in scope (priority) and removed p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority) labels Apr 8, 2024
@danielklein-arch
Copy link

@alvarosabu Hi, just stumbled upon this issue when I was solving the same problem but with useLoader. Based on your response to this issue I guess it will be typing issue as well

@alvarosabu
Copy link
Member

@bperel @danielklein-arch please update the core to https://github.com/Tresjs/tres/releases/tag/3.8.1

@kleinpetr
Copy link

@alvarosabu I've upgraded deps in the nuxt module we use :) Tresjs/nuxt#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2-edge-case Bug, but has a workaround or limited in scope (priority) regression The issue only appears after a new release
Projects
Status: No status
4 participants