Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deltatime Documentation Inaccuracy #750

Closed
5 tasks done
nart4hire opened this issue Jun 29, 2024 · 0 comments
Closed
5 tasks done

Deltatime Documentation Inaccuracy #750

nart4hire opened this issue Jun 29, 2024 · 0 comments
Labels
docs Improvements or additions to documentation good first issue Good for newcomers p1-chore Doesn't change end-user code behavior (priority) PR welcome

Comments

@nart4hire
Copy link
Contributor

Describe the bug

In the docs, delta is described as milliseconds from last frame, which is inaccurate since under the hood it uses Clock.deltaTime() which is in seconds.

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-tuauqe?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

Just use the useLoop function as described in the documentation

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700K
    Memory: 21.41 GB / 31.77 GB
  Binaries:
    Node: 21.7.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.2 - C:\ProgramData\chocolatey\bin\pnpm.EXE
  Browsers:
    Edge: Chromium (126.0.2592.81)
    Internet Explorer: 11.0.22621.3527

Used Package Manager

pnpm

Code of Conduct

@andretchen0 andretchen0 added docs Improvements or additions to documentation good first issue Good for newcomers PR welcome p1-chore Doesn't change end-user code behavior (priority) labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation good first issue Good for newcomers p1-chore Doesn't change end-user code behavior (priority) PR welcome
Projects
Status: No status
Development

No branches or pull requests

3 participants