puppet error on Ubuntu 20 LTS

[djgreen]

Error: Could not set 'file' on ensure: No such file or directory - A directory component in /etc/csh/login.d/lmod.csh20220420-10341-1vpkbzp.lock does not exist or is a dangling symbolic link (file: /etc/puppetlabs/code/environments/ece_production/modules/lmod/manifests/load.pp, line: 49)
Error: Could not set 'file' on ensure: No such file or directory - A directory component in /etc/csh/login.d/lmod.csh20220420-10341-1vpkbzp.lock does not exist or is a dangling symbolic link (file: /etc/puppetlabs/code/environments/ece_production/modules/lmod/manifests/load.pp, line: 49)
Wrapped exception:
No such file or directory - A directory component in /etc/csh/login.d/lmod.csh20220420-10341-1vpkbzp.lock does not exist or is a dangling symbolic link
Error: /Stage[main]/Lmod::Load/File[lmod-csh-load]/ensure: change from 'absent' to 'file' failed: Could not set 'file' on ensure: No such file or directory - A directory component in /etc/csh/login.d/lmod.csh20220420-10341-1vpkbzp.lock does not exist or is a dangling symbolic link (file: /etc/puppetlabs/code/environments/ece_production/modules/lmod/manifests/load.pp, line: 49)

Noticing the above error when running on Ubuntu 20 LTS.

[djgreen]

Nevermind, realized that I wasn't installing csh or tcsh on my Ubuntu 20 systems. When I forced this, the issue went away.

Of course, not sure that it should be required if we weren't using it...

[treydock]

Did you happen to define a different list of runtime packages? This module should have already handled install csh and tcsh unless that list of packages was re-defined.

[djgreen]

We haven't changed any of your code if that's what you're asking. We just call it. Where in your code do you force the installation of those packages?

[treydock]

Packages are listed here:

puppet-lmod/data/os/Debian.yaml

Lines 9 to 18 in 665ac8d

	lmod::runtime_packages:
	- 'lua5.3'
	- 'lua-filesystem'
	- 'lua-json'
	- 'lua-posix'
	- 'lua-term'
	- 'tcl8.6'
	- 'csh'
	- 'tcsh'
	- 'zsh'

They are installed for source and "none" install method here:

puppet-lmod/manifests/install.pp

Lines 31 to 40 in 665ac8d

	'source','none': {
	if $lmod::install_method == 'source' {
	include lmod::install::source
	Class['lmod::install'] -> Class['lmod::install::source']
	}
	if $lmod::ensure == 'present' {
	ensure_packages($lmod::runtime_packages, {'require' => $package_require})
	ensure_packages($lmod::build_packages, {'require' => $package_require})
	}
	}

However the default install method is "package" so it would seem maybe the Lmod package for Ubuntu 20.04 is not depending on tcsh or csh? Notice one gap in the module's testing is it doesn't do acceptance testing for default package install, which is curious. I'm looking into that as I forget why that is.

[djgreen]

Checked our config, and yes, we're using "install_method => 'package',"

[treydock]

Fix for this will be released with v3.2.0 once Github Actions complete.