Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keycloak-oidc providerid and other new parameters #155

Merged
merged 1 commit into from
Sep 23, 2020
Merged

add keycloak-oidc providerid and other new parameters #155

merged 1 commit into from
Sep 23, 2020

Conversation

aba-rechsteiner
Copy link
Contributor

No description provided.

@treydock
Copy link
Owner

@aba-rechsteiner Could you please add some acceptance tests to spec/acceptance/8_identity_provider_spec.rb and appropriate additions to unit tests under spec/unit/puppet/type/keycloak_identity_provider_spec.rb. If you need any help with that let me know.

@treydock
Copy link
Owner

Also once changes are made please squash commits into single commit.

@treydock treydock merged commit 3d8fea1 into treydock:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treydock treydock treydock left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aba-rechsteiner @treydock