Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scriptSig and witness to transaction vin/vout #522

Closed
szymonlesisz opened this issue Nov 25, 2020 · 2 comments
Closed

Add scriptSig and witness to transaction vin/vout #522

szymonlesisz opened this issue Nov 25, 2020 · 2 comments

Comments

@szymonlesisz
Copy link

szymonlesisz commented Nov 25, 2020 •
edited
Loading

This information is required by trezor-connect > firmware to implement new "replace-by-fee" feature.

they can be sent optionally, only in rbf transactions
@szymonlesisz szymonlesisz mentioned this issue Nov 25, 2020
Closed
martinboehm added a commit that referenced this issue Nov 27, 2020
@martinboehm
Return for mempool transactions coinSpecificData #522
a1e932a
martinboehm added a commit that referenced this issue Dec 4, 2020
@martinboehm
Return for mempool transactions coinSpecificData #522
fc267ed
sidhujag pushed a commit to syscoin/blockbook that referenced this issue Dec 23, 2020
@martinboehm
Return for mempool transactions coinSpecificData trezor#522
892d389
@szymonlesisz
Copy link
Author

turns out i didn't need it. i've just calculated missing fields from the data that i already have

@martinboehm
Copy link
Contributor

I will leave the functionality there. Apart from a small network overhead it does not cause any problems.

bidoudan pushed a commit to stibits-inc/blockbook that referenced this issue Jul 4, 2022
@martinboehm
Return for mempool transactions coinSpecificData trezor#522
0debd60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szymonlesisz @martinboehm