-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decred support #216
Merged
Merged
Add decred support #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinboehm
reviewed
Jun 27, 2019
Hi, when building decred blockbook, I got the following error:
Please add your Gopkg.toml/lock to the PR. |
martinboehm
reviewed
Jul 1, 2019
I am afraid that you took out too much :) Now I get
|
@martinboehm Sorry about that please check it again now. Kindly let me know when we can discuss the issue highlighted in this PR's description. |
bidoudan
pushed a commit
to stibits-inc/blockbook
that referenced
this pull request
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the major issues are fixed apart from a tiny issue resulting from how decred's (Proof of stake) P.O.S. works. Blocks in decred's block chain are validated or invalidated by the consecutive block mined. We therefore implemented a hack that only allows syncing of blocks with at least one confirming block so as to only push blocks which have been validated to the blockbook's db.
The major concern has been referenced here: #213 (comment)
The decred's best block (doesn't have a confirming block thus can't be synced) txs are listed together with other mempool txs in the mempool page. All the data for this block's txs in the mempool is correct apart from from the block height and the block hash field.
Possible ways to fix this could be:
BlockHeight
andBlockHash
could be added toTx
struct and before executing this code those two fields provided could be used instead if not empty.