Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start uploading Suite binaries to data.trezor.io #34

Closed
1 task
tsusanka opened this issue Dec 29, 2021 · 10 comments
Closed
1 task

Start uploading Suite binaries to data.trezor.io #34

tsusanka opened this issue Dec 29, 2021 · 10 comments
Assignees

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Dec 29, 2021

Suite landing page is currently part of Suite repository. With the upcoming new eshop we have discussed with @Hermez-cz that we would like to have trezor.io/suite part of the trezor.io ecosystem. Because of that it does not make much of a sense to maintain Suite LP as part of Suite, it will be done in the shop from scratch. This will also help that the LP will not be bound to Suite release cycle.

To inform about the latest version and offer download links we need to fetch the latest Suite release info via Github API. As Github throttles the download speed we do not want to fetch the binaries from there though.

My suggestion is to upload them to data.trezor.io/suite and simply replace the Github URL from https://github.com/trezor/trezor-suite/releases/download/v21.12.2/Trezor-Suite-21.12.2-linux-x86_64.AppImage to https://data.trezor.io/suite/v21.12.2/Trezor-Suite-21.12.2-linux-x86_64.AppImage (we can bikeshed the folder structure). Note that this would also help trezor/trezor-suite#4692.

We need to:

  • Modify deployment jobs in Suite to start uploading Suite releases to data.trezor.io as well.

That's it?

In future I can imagine publishing firmware releases on firmware Github as well and mirroring them here instead of adding them manually. But that is for future.

cc @prusnak @vdovhanych @matejkriz

@tsusanka
Copy link
Contributor Author

tsusanka commented Jan 18, 2022

@vdovhanych do you think you could do this when you have a sec? :) Only if it is a low-hanging fruit.

@vdovhanych
Copy link
Member

Will try to finish it today, btw will we want to commit the binaries to the data repository, no right ?

@prusnak
Copy link
Member

prusnak commented Jan 18, 2022

I already committed the binaries in 8051e34

@vdovhanych
Copy link
Member

I already committed the binaries in 8051e34

i meat suite app packages, sorry.

@tsusanka
Copy link
Contributor Author

I mean we can do both: upload Suite to data.trezor.io and commit here. However in the original post I indeed meant only uploading to data.trezor.io as I am not sure committing them here gives us something. We have to do it manually and the source of truth for Suite are Github releases anyway. So what advantage does it have committing them here? Consistency is a fair point, but maybe that's it?

So basically, I am just not sure it is worth it. We could also in future migrate firmwares to Github releases..

@tsusanka
Copy link
Contributor Author

Now that I think of it, maybe it would cause more harm than good having Suite on S3 but not here? And the best way to move forward is to simple add Suite binaries manually for now to have the S3 bucket consistent with this repo. And then rework it at some point in future. What do you think?

@vdovhanych
Copy link
Member

@tsusanka consistency only, it won't bring any advantage having it committed here. But at least the setup would be the same as is. Meaning we add binaries and packages here and then it gets deployed to s3.

@tsusanka
Copy link
Contributor Author

tsusanka commented Jun 9, 2022

Let's finish this.

Thx to trezor/trezor-suite#5214 we are getting closer to make trezor/trezor-suite#4692 a reality and for that we need this one.

Upon further consideration I think we should push as much automation as possible. Let's deploy to S3 directly then. I have filed a PR explaining this: #39. @vdovhanych could you please review and then do the CI part in Suite?

@vdovhanych
Copy link
Member

Addressed here trezor/trezor-suite#5594

@tsusanka
Copy link
Contributor Author

tsusanka commented Jun 15, 2022

Ok, so this is not that simple as I thought (summary here). We will first discuss properly in trezor/trezor-suite#4692 and see what options there are.

I am closing this issue as we indeed are not sure what we actually want yet. We will reopen or make a new one then. Sorry for the fuzz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants