-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: suite-desktop deploy to data.trezor.io and some ci updates #5594
Conversation
vdovhanych
commented
Jun 9, 2022
- chore(ci): move autoupdate test deploy to deploy stage
- feat(ci): deploy suite-desktop to data.trezor.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will it work? 🙂
It should but i want to test it before we merge it :) So ill stick with |
Ok ping me pls, when I should re-review. |
I don't see the way how to use this in our auto-update flow. We can't check the new releases on Github and then download just the binaries from s3. We need to be able to check the releases directly on the s3 too. So we need also something like https://data.trezor.io/suite/releases/latest to be able to check for update on stable URL. And we need to think about where we're going to get the release notes. So far we are reading them from Github. But we could avoid using Github for auto-update completely if we put release notes directly in latest-xx.yml files (but then it's not dynamic and so easy to edit). |
@vdovhanych now that I think about it can't we use cdn.trezor.io and not do this thing at all? Maybe we have discussed this already and I do not remember, but why not just cache responses to GitHub on the CDN similarly as we do with coin prices? And instead of Github, Suite will contact cdn.trezor.io which will return cached response from GitHub. |
So I managed to proxy GitHub releases with CloudFront meaning every request through this(temporary for now) domain will be cached and served from amazon to customers. This way we only need to change the root URL for auto-updater and it should find all the files and all the paths that are present on Github now. @matejkriz is not sure about this solution and if it will be possible. Another option is to upload it to our storage and also provide it through CloudFront this way we would need to have something like |
Ok, let's not do it this wait (yet). Let's assess priority of this first properly in #4692 and see what options there are then. Sorry for the fuzz! |