Skip to content

Commit

Permalink
extmod/modussl_mbedtls: Allow to compile with MBEDTLS_DEBUG_C disabled.
Browse files Browse the repository at this point in the history
With MBEDTLS_DEBUG_C disabled the function mbedtls_debug_set_threshold()
doesn't exist.  There's also no need to call mbedtls_ssl_conf_dbg() so a
few bytes can be saved on disabling that and not needing the mbedtls_debug
callback.
  • Loading branch information
dpgeorge committed Sep 6, 2017
1 parent 68c2817 commit beeb748
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion extmod/modussl_mbedtls.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ struct ssl_args {

STATIC const mp_obj_type_t ussl_socket_type;

static void mbedtls_debug(void *ctx, int level, const char *file, int line, const char *str) {
void mbedtls_debug(void *ctx, int level, const char *file, int line, const char *str) {
printf("DBG:%s:%04d: %s\n", file, line, str);
}

Expand Down Expand Up @@ -123,8 +123,10 @@ STATIC mp_obj_ssl_socket_t *socket_new(mp_obj_t sock, struct ssl_args *args) {
mbedtls_x509_crt_init(&o->cert);
mbedtls_pk_init(&o->pkey);
mbedtls_ctr_drbg_init(&o->ctr_drbg);
#ifdef MBEDTLS_DEBUG_C
// Debug level (0-4)
mbedtls_debug_set_threshold(0);
#endif

mbedtls_entropy_init(&o->entropy);
const byte seed[] = "upy";
Expand All @@ -144,7 +146,9 @@ STATIC mp_obj_ssl_socket_t *socket_new(mp_obj_t sock, struct ssl_args *args) {

mbedtls_ssl_conf_authmode(&o->conf, MBEDTLS_SSL_VERIFY_NONE);
mbedtls_ssl_conf_rng(&o->conf, mbedtls_ctr_drbg_random, &o->ctr_drbg);
#ifdef MBEDTLS_DEBUG_C
mbedtls_ssl_conf_dbg(&o->conf, mbedtls_debug, NULL);
#endif

ret = mbedtls_ssl_setup(&o->ssl, &o->conf);
if (ret != 0) {
Expand Down

0 comments on commit beeb748

Please sign in to comment.