This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Allow custom runxfail #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now selectively runxfail certain tests. This is useful for
accepting PRs into trezor-core:
1. trezor-core is going to get a pytest.ini that sets xfail_strict.
That means that if an `xfail`ed test actually passes, that will
break the test suite. So it will be visible when we implement
a feature for which tests exist.
2. To allow PRs to pass the test suite without touching python-trezor
directly, we add a new pytest.ini option: run_xfail.
This adds a list of markers which will ignore `xfail`.
So:
2.1 First, the python-trezor PR marks the tests with the name
of the feature. This commit already does that: Lisk tests
are marked `@pytest.mark.lisk`, NEMs are `@pytest.mark.nem`,
etc.
The tests will be also marked with `xfail`, because the
feature is not in core yet.
2.2 Then, the trezor-core PR implements the feature, which makes
the `xfail`ed tests pass. That breaks the test suite.
2.3 To fix the test suite, the core PR also adds a `run_xfail`
to `pytest.ini`: `run_xfail = lisk`.
(it can take a list: `run_xfail = lisk nem stellar`)
That will make the test suite behave as if the tests are not
`xfail`ed. If the feature is implemented correctly, the tests
will pass.
2.4 When the PR is accepted to core, the next step should be
a PR to python-trezor that removes the `xfail`s. After that,
we should also remove the `run_xfail` option, just to be tidy.
|
Very nice! utACK
|
matejcik
added a commit
to trezor/trezor-core
that referenced
this pull request
May 21, 2018
missed Stellar tests, plus Ethereum, for good measure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now selectively runxfail certain tests. This is useful for accepting PRs into trezor-core:
pytest.inithat setsxfail_strict.That means that if an
xfailed test actually passes, that will break the test suite. So it will be visible when we implement a feature for which tests exist.run_xfail. This adds a list of markers which will ignorexfail.So:
@pytest.mark.lisk, NEMs are@pytest.mark.nem, etc.The tests will be also marked with
xfail, because the feature is not in core yet.xfailed tests pass. That breaks the test suite.run_xfailtopytest.ini:run_xfail = lisk. (it can take a list:run_xfail = lisk nem stellar)That will make the test suite behave as if the tests are not
xfailed. If the feature is implemented correctly, the tests will pass.xfails. After that, we should also remove therun_xfailoption, just to be tidy.