Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

blockbook missing locktime #344

Closed
wants to merge 1 commit into from
Closed

blockbook missing locktime #344

wants to merge 1 commit into from

Conversation

brianddk
Copy link
Contributor

@brianddk brianddk commented Dec 6, 2018

blockbook doesn't seem to always return locktime which breaks PAYTOADDRESS in versions < 0.11. Defaulting to zero for cross-compatibility with existing blockbook servers.

BTW, this fires from trezorctl sign-tx if that wasn't clear.

blockbook doesn't seem to always return blocktime which breaks PAYTOADDRESS in versions < 0.11 default to zero for cross-compatibility with blockbook.
@matejcik
Copy link
Contributor

matejcik commented Dec 6, 2018

This is fixed in 0.11 which was just released.

Users of trezorctl should upgrade to 0.11 and I'm not aware of other applications that would require 0.10.x and rely on the built-in TxApi, so I'm going to close this.

@matejcik matejcik closed this Dec 6, 2018
@brianddk
Copy link
Contributor Author

brianddk commented Dec 6, 2018

I'm not aware of other applications that would require 0.10.x

I believe that Electrum 3.2.3 still requires 0.10.x (ie its not forward compatible). Other conflicts prevent me from testing Electrum@master but I might later. Plus all the Electrum forks (BCH, LTC, FTC.. etc) are quite a few commits behind Electrum@master so they are even deeper in the hole.

I've patched my install since I'm not really using locktime or LN in any of my TXNs presently.

@matejcik
Copy link
Contributor

matejcik commented Dec 6, 2018

There's spesmilo/electrum#4875 which is likely to end up in Electrum 3.3 - I'm told that's going to be out in a week or two.

@brianddk
Copy link
Contributor Author

brianddk commented Dec 6, 2018

There's spesmilo/electrum#4875 which is likely to end up in Electrum 3.3 - I'm told that's going to be out in a week or two.

Thx... Looks to be in master @ spesmilo/electrum@c33c907#diff-d340122daff15ed7703f584dd191bc92

I just need to work on getting Electrum@master building on Unbuntu 16.04 (personal problem ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants