-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand type checking to the whole src folder #642
Comments
Would be also nice to generate HTML report when running mypy: https://mypy.readthedocs.io/en/stable/command_line.html#report-generation And perhaps fail CI if type coverage falls bellow threshold like we do for test coverage? |
I totally agree! Maybe we can add the CI check already? So we make sure the coverage does not degrade. |
In the current state the report only shows |
It was nonsense. I was thinking about adding a CI job to check if the current mypy coverage did not degrade but we obviously already have that - it is part of |
mostly fixed via #1939 what remains is the Monero app, for which I'm keeping this issue open |
Monero remains to be done |
Currently we run mypy on src/main.py, which means not everything in the src folder is being tested by mypy.
The text was updated successfully, but these errors were encountered: