Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coinmarket): buy/sell/exchange detail #12507

Closed
adderpositive opened this issue May 21, 2024 · 0 comments · Fixed by #12582
Closed

feat(coinmarket): buy/sell/exchange detail #12507

adderpositive opened this issue May 21, 2024 · 0 comments · Fixed by #12582
Assignees
Labels
+Invity Related to Invity project

Comments

@adderpositive
Copy link
Contributor

adderpositive commented May 21, 2024

Description

A small refactoring mainly focused on reducing duplicities:

  • The files useCoinmarketBuyDetail.ts, useCoinmarketSellDetail.ts and useCoinmarketExchangeDetail.ts - merged into one file useCoinmarketDetail.ts and moved to the /coinmarket folder.
  • Created useCoinmarketWatchTrade.ts in the /coinmarket folder with the useCoinmarketWatchTrade hook which is integrates three very similar functions - useWatchBuyTrade, useWatchSellTrade and useWatchExchangeTrade.
  • Created watchTrade function in invityAPI.ts, combining watchBuyTrade, watchSellTrade and watchExchangeTrade functions.
  • Used types from the newly created file coinmarketDetail.ts in the /types folder (a focus on merging types to one place).
  • Generally, using folders to separate Coinmarket from other features.
  • Spend and Savings are not included and are not going to be further supported.
@adderpositive adderpositive added the +Invity Related to Invity project label May 21, 2024
@adderpositive adderpositive self-assigned this May 21, 2024
@adderpositive adderpositive changed the title refactor(coinmarket): buy/sell/exchange detail feat(coinmarket): buy/sell/exchange detail May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+Invity Related to Invity project
Projects
Status: ✅ Approved
1 participant