Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coinmarket): refactor buy/sell/exchange detail #12582

Merged

Conversation

adderpositive
Copy link
Contributor

Description

A small refactoring mainly focused on reducing duplicities:

  • The files useCoinmarketBuyDetail.ts, useCoinmarketSellDetail.ts and useCoinmarketExchangeDetail.ts - merged into one file useCoinmarketDetail.ts and moved to the /coinmarket folder.
  • Created useCoinmarketWatchTrade.ts in the /coinmarket folder with the useCoinmarketWatchTrade hook which is integrates three very similar functions - useWatchBuyTrade, useWatchSellTrade and useWatchExchangeTrade.
  • Created watchTrade function in invityAPI.ts, combining watchBuyTrade, watchSellTrade and watchExchangeTrade functions.
  • Used types from the newly created file coinmarketDetail.ts in the /types folder (a focus on merging types to one place).
  • Generally, using folders to separate Coinmarket from other features.
  • Spend and Savings are not included and are not going to be further supported.

@adderpositive adderpositive added the +Invity Related to Invity project label May 27, 2024
@adderpositive adderpositive self-assigned this May 27, 2024
@adderpositive adderpositive linked an issue May 27, 2024 that may be closed by this pull request
@adderpositive adderpositive force-pushed the feat/coinmartket-detail-refactor branch from f314e8a to 7969a8c Compare May 27, 2024 10:41
@adderpositive adderpositive merged commit 7969a8c into feat/coinmarket-redesign May 27, 2024
8 of 9 checks passed
@adderpositive adderpositive deleted the feat/coinmartket-detail-refactor branch May 27, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+Invity Related to Invity project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(coinmarket): buy/sell/exchange detail
1 participant