Coin control prerequisite: "send max" switch #6152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
matejkriz
reviewed
Aug 30, 2022
packages/suite/src/views/wallet/send/components/Outputs/components/Amount/index.tsx
Show resolved
Hide resolved
|
except missing animation during switch transition it works nice for me 👍 |
komret
force-pushed
the
feat/send-max-switch
branch
from
4269217
to
c9989e5
Compare
matejkriz
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the "send max" button with a switch.
Description
We want to communicate that setting max amount is a state rather than an action - the user can add or remove UTXOs after checking the switch and the amount in the input field always adjusts to be the maximum amount composed from available/selected UTXOs.
There is also a minor improvement in the
Switchcomponent - when given anid, it can be controlled by clicking on its label.Related Issue
#2770
Screenshots (if appropriate):
QA: Please see above. There are no changes to the behaviour from the previous version with the button.