test(suite-web): adapt e2e tests to changes in #12472 #12588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
commented
May 27, 2024
| @@ -23,35 +23,43 @@ describe('Firmware', () => { | |||
|
|
|||
| // check seed screen | |||
| cy.getTestElement('@modal/close-button').should('be.visible'); // modal is cancellable at this moment | |||
| cy.wait(1000); // wait for animation to finish before taking a screenshot | |||
There was a problem hiding this comment.
not needed, screenshots have been turne off couple of years ago, so why waste time?
andrcj
approved these changes
May 27, 2024
mroz22
force-pushed
the
fix-firmware-suite-web-e2e
branch
from
df2f78f
to
e49b3d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description in comments.
i have also removed a skipped tests, it has been skipped for couple of years now so I gues we may live without it.