chore(connect): fw-update: add error message when binary is too small #12472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
connect/fw-update-richer-error
branch
from
dd44cac
to
2a316f7
Compare
mroz22
force-pushed
the
connect/fw-update-richer-error
branch
from
b8f61f2
to
c5fe863
Compare
mroz22
force-pushed
the
connect/fw-update-richer-error
branch
from
c5fe863
to
7a72ca9
Compare
marekrjpolak
approved these changes
May 24, 2024
mroz22
added a commit
that referenced
this pull request
May 27, 2024
mroz22
added a commit
that referenced
this pull request
May 27, 2024
mroz22
added a commit
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening this instead of #12440
the goal is to give a more descriptive error in case connect downloads something which is apparently not a valid firmware. In that case it doesn't make sense to send this invalid binary into the device. Also since we decided not to make fw update possible in feature branches, I believe it will be useful to find out whats going on when QA reports this "bug" in the future.