This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Fix android speed by skipping base58 validation #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly speeds up Android version of webwallet, by ignoring expansive xpub base58 validation
|
We have forked bitcoinjs-lib that optionally skips the validation https://github.com/karel-3d/bitcoinjs-lib/commit/ce39c9507cc472e63c4b524d7daea65a21dd2a9e The validation is very expensive (even more on android), even when it's totally useless (see profiler in chat) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly speeds up Android version of webwallet, by ignoring expensive xpub base58 validation