Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve annotation when GAM cannot assess emerging status #103

Closed
damianooldoni opened this issue Feb 8, 2023 · 4 comments · Fixed by #104
Closed

Improve annotation when GAM cannot assess emerging status #103

damianooldoni opened this issue Feb 8, 2023 · 4 comments · Fixed by #104
Assignees

Comments

@damianooldoni
Copy link
Collaborator

An annotation is added when no emerging status can be assesses by GAM:
"The emergence status cannot be assessed". This was done in #96 after #91.

In the TrIAS emerging status workflow we use decision rules to assess the emerging status if GAM cannot help, so that annotation should be replace by:

"The emerging status cannot be assessed by GAM"

Notice also that I would replace emergence with emerging as we use in workflows everywhere.

See e.g. this screenshot taken from this GAM output plot as reference for this issue. @timadriaens, @mvarewyck: let me know if you agree on this.
image

@mvarewyck
Copy link
Collaborator

Fine for me.

@timadriaens
Copy link
Member

I would leave out the "emerging/emergence" and just say ""The status cannot be assessed by GAM"

@SanderDevisscher
Copy link
Contributor

I agree with @timadriaens

@damianooldoni
Copy link
Collaborator Author

Thanks for fast reply. I will implement your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants