Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BiocStyle to Suggests #39

Closed
HenrikBengtsson opened this issue Apr 7, 2022 · 3 comments
Closed

Add BiocStyle to Suggests #39

HenrikBengtsson opened this issue Apr 7, 2022 · 3 comments

Comments

@HenrikBengtsson
Copy link

Hi. I'm running reverse dependency checks on parallelly, I noticed that your package lacks Suggests: BiocStyle, cf. https://github.com/HenrikBengtsson/parallelly/blob/develop/revdep/problems.md#biscuiteer. Without, it you get:

*** checking re-building of vignette outputs ... WARNING

Error(s) in re-building vignettes:
  ...
--- re-building ‘biscuiteer.Rmd’ using rmarkdown
Error: processing vignette 'biscuiteer.Rmd' failed with diagnostics:
there is no package called ‘BiocStyle’
--- failed re-building ‘biscuiteer.Rmd’

SUMMARY: processing the following file failed:
  ‘biscuiteer.Rmd’

Error: Vignette re-building failed.
Execution halted
@jamorrison
Copy link
Contributor

Thanks @HenrikBengtsson for bringing this to our attention. BiocStyle has been added to Suggests and pushed to Bioconductor devel.

@HenrikBengtsson
Copy link
Author

Thanks. If not too much work, do you mind patching also Bioc release?

@HenrikBengtsson
Copy link
Author

Just ran into this problem again while revdep check parallelly + future; do you mind push this fix also the the Bioc release branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants