[RFC] Aucmds refactor and Downloadpost #1495
Conversation
I've done away with the string literal type signature in loadaucmds and replaced it with an internal type of AUTOCMDS, this means that the AUTOCMDS object (formerly an array) is now the de facto truth of which autocmds exist in the extension.
This addresses issues tridactyl#810 and tridactyl#807. An optional argument of the type AutocmdArgs can be passed to loadaucmds. Only a small subset of the variables mentioned in tridactyl#810 are implemented. I think it's better to implement these as the need/request arrives but for the DownloadPost aucmd I felt like this was the most straightforward way to implement. The parseaucmdargs function takes an aucmd and looks for the pattern "<param"> where param is any of the keys provided by AutocmdArgs and replaces the pattern with the matching information from the args. Example usage: `:au DownloadPost .* fillcmdline "<file>"` Will print the full path of the downloaded file on the cmdline.
|
|
||
| //#content_helper | ||
| export function parseaucmdargs(aucmd: string, args: AutocmdArgs): string { | ||
| const re = /^\"<(\w+)>\"$/ |
There was a problem hiding this comment.
How hard would it be to factor this out to into a well-contained library so you can add some simple test cases? It looks right, and I expect that Pentadactyl collected enough real-world observations to establish that strings like <file> and such didn't occur that often in URLs, but I'd prefer to not start accidentally replacing random other <....> pairs.
There was a problem hiding this comment.
I'm all for factoring it out into a library, the problem there would be the implementation. If we remove loadaucmds from excmds along with the parser I'm guessing it'd have to live in the content script somehow similar to what autocontainers does in the background.
The current implementation is pretty heavy handed so I'm nigh sure you won't get it mixed with urls or other things. I split the aucmd string on spaces and check for exact matches on ^"<WORD>"$. The problem with this is that you can't combine params, "<file> <url>" will not be matched since the split on space would create "<file> and <url>" which won't match the regex.
|
@bovine3dom it doesn't behave all that different either if I remember correctly. I must admit I had to read over what I had originally proposed here as it's been a while, but something very similar could be set up for webrequests. |
This addresses issues #810 and #807. An optional argument of the type
AutocmdArgscan be passed toloadaucmds. Only a small subset of the variablesmentioned in #810 are implemented. I think it's better to implement these as the
need/request arrives but for the
DownloadPostaucmd I felt like this was themost straightforward way to implement.
The
parseaucmdargsfunction takes an aucmd and looks for the pattern "<param">where param is any of the keys provided by
AutocmdArgsand replaces the patternwith the matching information from the args.
Example usage:
:au DownloadPost .* fillcmdline "<file>"Will print the full path of the downloaded file on the cmdline.
I'm not attached to the naming convention but it's the same as pentadactyl used.
I have yet to write the documentation for the feature.
Any comments welcome.