Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment lines can start with # #7

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

rddunphy
Copy link
Contributor

Apparently leading whitespace is ignored, too.

Apparently leading whitespace is ignored, too.
@alerque
Copy link
Collaborator

alerque commented Nov 30, 2022

You may well be right, but do you have any references to upstream documentation or perhaps the actual implementation code that backs up this assertion?

@rddunphy
Copy link
Contributor Author

I'm actually not sure if there is any documentation, but it's mentioned in a couple of comments (e.g. here). The relevant code is at the end of config_rc.ts:

return excmds.filter(
	x =>
		/\S/.test(x) &&
		!x.trim().startsWith('"') &&
		!x.trim().startsWith("#"),
)

@alerque
Copy link
Collaborator

alerque commented Nov 30, 2022

Thanks for tracking that down.

@alerque alerque merged commit fdd069b into tridactyl:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants