Adding hint kwarg upon LightRay load to break degeneracy in new yt loader #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue. |
Pull Request Test Coverage Report for Build 65115f20-f62e-457b-9def-1ddfb6578670
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in yt (PR #3666) breaks trident when trident reloads a LightRay object into working memory. This one-line change provides a "hint" that breaks the degeneracy in Datasets types that yt is confused about, and allows Trident to continue working the way it used to.
This bug was discovered by @evaneschneider , so I'll let her comment on how well this fix works for her case.