This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does three things
signtool
if a certificate was actually specified in the configosslsigncode
binaries included in this repository on OSX and Linux (commented out)The last item is commented out because
osslsigncode_osx
is currently incorrectly linked against/opt/local/lib/libcrypto.1.0.0.dylib
which is not part of OSX. Presumably it was built while some third party package manager like homebrew was interfering. The corresponding system library is/usr/lib/libcrypto.dylib
andosslsigncode_osx
should be rebuilt using it.