Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tekton target documentation #66

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Add Tekton target documentation #66

merged 4 commits into from
Nov 10, 2020

Conversation

cab105
Copy link
Contributor

@cab105 cab105 commented Nov 10, 2020

The original Tekton user documentation was ported over from the development repo assuming the target would run on-prem. This guide provides details on how to create a task, how to create the target, and what the event should look like.

@cab105 cab105 added the GA label Nov 10, 2020
@cab105 cab105 added this to the v1.0.0 milestone Nov 10, 2020
@cab105 cab105 self-assigned this Nov 10, 2020
@cab105 cab105 linked an issue Nov 10, 2020 that may be closed by this pull request
docs/targets/index.md Outdated Show resolved Hide resolved
@@ -10,20 +10,15 @@ The following is a list of Triggermesh event destinations known as `Targets`. So
* [AWS SQS](./awssqs.md): Forward event payload to AWS Simple Queueing Service (SQS).
* [AWS Kinesis](./awskinesis.md): Forward event payload to AWS Kinesis.
* [AWS EventBridge](./awseventbridge.md): Forward arbitrary events to AWS EventBridge.
* [Confluent](./confluent.md): Forward events to Confluent Kafka.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we certain we want to show this to the public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am cleaning this up, and it will be updated in the next PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this diff belongs in the "next PR" then?

Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Only 3 minor comments and we probably need to disable the links to Confluent and Google Sheets.

@@ -1,85 +1,75 @@
# Tekton Pipeline Event Target for Knative Eventing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Tekton Pipeline Event Target for Knative Eventing
# Event Target for Tekton Pipeline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that does look cleaner.

docs/targets/tekton.md Outdated Show resolved Hide resolved
docs/targets/tekton.md Outdated Show resolved Hide resolved
@cab105 cab105 merged commit 911bca2 into master Nov 10, 2020
@cab105 cab105 deleted the tekton-doc branch November 10, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate target docs
2 participants