-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tekton target documentation #66
Conversation
docs/targets/index.md
Outdated
@@ -10,20 +10,15 @@ The following is a list of Triggermesh event destinations known as `Targets`. So | |||
* [AWS SQS](./awssqs.md): Forward event payload to AWS Simple Queueing Service (SQS). | |||
* [AWS Kinesis](./awskinesis.md): Forward event payload to AWS Kinesis. | |||
* [AWS EventBridge](./awseventbridge.md): Forward arbitrary events to AWS EventBridge. | |||
* [Confluent](./confluent.md): Forward events to Confluent Kafka. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we certain we want to show this to the public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am cleaning this up, and it will be updated in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this diff belongs in the "next PR" then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Only 3 minor comments and we probably need to disable the links to Confluent and Google Sheets.
docs/targets/tekton.md
Outdated
@@ -1,85 +1,75 @@ | |||
# Tekton Pipeline Event Target for Knative Eventing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Tekton Pipeline Event Target for Knative Eventing | |
# Event Target for Tekton Pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks that does look cleaner.
The original Tekton user documentation was ported over from the development repo assuming the target would run on-prem. This guide provides details on how to create a task, how to create the target, and what the event should look like.