-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak on startup #1052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux: docker requires additional capabilities: google/sanitizers#764 macOS: detect_leaks=1 is unsupported as of Jul 2020
we do not need selection when clicking outside of the box
and no memory leaks occure
When closing soon after opening, memory leaks and read-freed happen
Download: |
khodand
pushed a commit
to khodand/trik-studio
that referenced
this pull request
Oct 25, 2020
* Fix memory leaks for trikV62QtsGeneratorTest * Fix leaking BrickFacktory * Fix memleak in b2d wrapper * Fix leaking QActions and few widgets * TravisCI: use default LSAN_OPTIONS Linux: docker requires additional capabilities: google/sanitizers#764 macOS: detect_leaks=1 is unsupported as of Jul 2020 * Rename confusing imageRect() * Remove strange oveloaded function, we do not need selection when clicking outside of the box * Repo: loadFromDisk always return correct empty repo and no memory leaks occure * Fix memleak when closing editor scene When closing soon after opening, memory leaks and read-freed happen * Avoid pointers to arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge leak happens in gesture manager if the scene is closed, whilst it is in initialization thread.
Also small fix for Range sensor image handling on mouse click (ignore clicks on grey area of a ray).