Update based on minor SWIG changes #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .cpp.cpp extension - link error when MPI disabled
|
@aprokop The CI seems to be failing because the CUDA docker image has apparently been deleted due to its age. Do you have time to upgrade the docker image? |
|
Seems like CI passed, but the status wasn't reported back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only substantial change is that
size_tis no longer equal to along(which it never should have been), so this is a bug fix. On most 64-bit platforms, I thinkc_size_tandc_long_longshould be equivalent: so this should not result in any downstream changes.