Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPORT_MAKEFILES: Can't seem to get Makefile.export.* to show up #11081

Closed
flintpierce opened this issue Sep 29, 2022 · 8 comments
Closed

EXPORT_MAKEFILES: Can't seem to get Makefile.export.* to show up #11081

flintpierce opened this issue Sep 29, 2022 · 8 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. type: new to Trilinos type: question

Comments

@flintpierce
Copy link

Question

@trilinos/<EXPORT_MAKEFILES>

I need to generate Makefile.export.* for the Trilinos packages I am building for use with another cmake project (LAMMPS). However, when I build Trilinos with:

-D Trilinos_ENABLE_EXPORT_MAKEFILES:BOOL=ON

I don't get any Makefile.export.* showing up.

@jhux2
Copy link
Member

jhux2 commented Sep 30, 2022

@jhux2
Copy link
Member

jhux2 commented Sep 30, 2022

@bartlettroscoe

@bartlettroscoe
Copy link
Member

@flintpierce, support for export makefiles was removed a while back to accommodate the upgrade to modern CMake. See #8598 and #9284. For a deep technical discussion of this, see TriBITSPub/TriBITS#299.

Sorry for the inconvenience.

@jhux2
Copy link
Member

jhux2 commented Sep 30, 2022

@flintpierce Please let us know if there's Trilinos documentation that references Makefile.export so that we can fix it.

@flintpierce
Copy link
Author

https://trilinos.github.io/pdfs/TrilinosBuildReference.pdf is where I found this. I have been looking for a case where someone used Trilinos in LAMMPS. I'm in the process of coupling LAMMPS to SIERRA Fuego, and for this I plan on using STK Coupling, which is part of Trilinos. However, I've had trouble finding anyone (except one case) where Trilinos libraries were pulled into LAMMPS. The one case I found used export Makefiles. I will have to keep looking. Thanks for the help.

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Sep 30, 2022

At:

it says:

The project Trilinos can generate export files for external CMake projects or external Makefile projects.

That was a mention of old support of export makefiles that did not get removed when support was removed. I will fix that.

bartlettroscoe added a commit to TriBITSPub/TriBITS that referenced this issue Sep 30, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Oct 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Nov 1, 2023
@github-actions github-actions bot closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. type: new to Trilinos type: question
Projects
None yet
Development

No branches or pull requests

3 participants