Stokhos(mask logic): MaskLogic::OP should take by const&

[romintomasetti]

Enhancement

@trilinos/stokhos

@etphipp

When we run tests using ensembles, we want to make floating-point equality checks (or at least comparison within a tolerance).

Making such thing sample-wise is ensured by using MaskLogic::OP.

I think these MaskLogic::OP should take Mask<T> by const&. Otherwise, it copies Mask<T> uselessly.

Trilinos/packages/stokhos/src/sacado/kokkos/vector/Stokhos_MP_Vector_MaskTraits.hpp

Lines 938 to 964 in 5aaae1a

	namespace MaskLogic{
	template<typename T> KOKKOS_INLINE_FUNCTION bool OR(Mask<T> m){
	return (((double) m)!=0.);
	}
	KOKKOS_INLINE_FUNCTION bool OR(bool m){
	return m;
	}
	template<typename T> KOKKOS_INLINE_FUNCTION bool XOR(Mask<T> m){
	return (((double) m)==1./m.getSize());
	}
	KOKKOS_INLINE_FUNCTION bool XOR(bool m){
	return m;
	}
	template<typename T> KOKKOS_INLINE_FUNCTION bool AND(Mask<T> m){
	return (((double) m)==1.);
	}
	KOKKOS_INLINE_FUNCTION bool AND(bool m){
	return m;
	}
	}

If you agree, I'll make a PR to fix this.

[romintomasetti]

@maartenarnst will also be interested 😉

[etphipp]

The compiler often eliminates the copy, but const& is better. A PR would be great, thanks!

[romintomasetti]

Here you go:

• stokhos: mask logic signature improvement (#12325) #12350

[github-actions]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[etphipp]

I’m retesting the linked PR to see what the status is.