-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping support for Makefile.export.* files with TriBITS/Trilinos refactoring to support modern CMake features #8498
Comments
Making this way more general could help: https://gitlab.kitware.com/paraview/paraview/-/blob/master/Clients/CommandLineExecutables/paraview-config.in. That is heavily ParaView-specific, but is an outline of what would be needed for something more generally. |
Aw, man. Those things are useful. |
@csiefer2, the goal would be to move customers to use CMake for their projects using Trilinos. |
Guess that just means I need to learn how to write cmake from scratch for little toy codes that use Trilinos... Do we have any documentation for that? |
Before these changes are pushed into Trilinos, we will have instructions and an example in Trilinos (probably in the demos directory). It's only a few lines of code to pull trilinos into a new cmake app. |
Related to:
|
Looks like there is some urgency for at least and example using |
CC: @rppawlo, @jwillenbring Turns out an example of how to build against Trilinos using CMake already exists under demos/buildAgainstTrilinos. I have no idea if that still works or not. I did not even know that this example even existed! I can test and update this example to make sure it works but then we need to protect this in PR testing. @trilinos/framework, could you consider setting up the PR builds to do an install of Trilinos and then build and test this example project? We need to ensure that example always works and it will also do some level of installation testing. |
This now builds without errors with Clang 10.0. (There was a build error before this update.) * Require CMake 3.17.1 which is the same minimum now required by Trilinos * Updated the documentation to use Markdown and use raw CMake and no do-cmake script * Deleted unneccasary do-cmake script * Deleted usage of a 'Trilinos_PREFIX' var and just use built-in CMake var CMAKE_PREFIX_PATH directly as documented in CMake documentation for 'find_package()' * Turn off warning from Kokkos about not suupporting C++ extensions * Fix build error with source code
…8498) If one is going to demonstrate how to use CTest one should also show good software engineering practicies like minimizing duplication. I also set the PROCESSORS property so that ctest -j<N>.
This now builds without errors with Clang 10.0. * Require CMake 3.17.1 which is the same minimum now required by Trilinos * Updated the documentation to use Markdown and use raw CMake and no do-cmake script * Deleted unneccasary do-cmake script * Deleted usage of a 'Trilinos_PREFIX' var and just use built-in CMake var CMAKE_PREFIX_PATH directly as documented in CMake documentation for 'find_package()' * Turned off warning from Kokkos about not suupporting C++ extensions * Fixed build error with the source code usage of Teuchos
…8498) If one is going to demonstrate how to use CTest one should also show good software engineering practicies like minimizing duplication. I also set the PROCESSORS property so that ctest -j<N>.
…8498) I removed the author and just gave the framework team email address for a contact.
I merged trilinos/trilinos.github.io#49 and now the page: looks to be updated including the link there to the updated text file: Last step is to merge an updated snapshot of TriBITS that removes support for |
Disabling support for Makefile.export.* files in Trilinos while TriBITS is refactored in TriBITSPub/TriBITS#299 that will remove support for this permanently.
PR #9284 removes support for |
…kefile-export-files Automatically Merged using Trilinos Pull Request AutoTester PR Title: Disable support for Makefile.export.* files (#8498) PR Author: bartlettroscoe
With the merge of PR #9284 just now, Trilinos 'develop' no longer supports the installation of |
…s:develop' (16c177b). * trilinos-develop: (71 commits) Tpetra: Remove some output from the Bug7758 test MueLu Stratimikos adapter: Enable half precision for factory-style PLs Tpetra: remove some deprecated usage ROL: implement the apply function for Thyra Vector Piro: changes to ROL adapters comply with ROL changes Piro: bug-fix in Piro::NOX_Solver Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280). Ifpack2: cleaning up unused variables in tests. Ctest: Adding Amesos2/Belos tests Ctest: Stuff failing on ride that worked on ascicgpu Ctest: Enabling non-UVM Ifpack2 tests Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp. Disable support for Makefile.export.* files (trilinos#8498) Tpetra: remove unused variable (copied too many times when breaking up a function) ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376) Ifpack2: adding missing logic for new tests. Belos: writing tests for 'long double' and 'float128' ScalarType. STK: Snapshot 06-11-21 17:50 Tpetra: remove comments that don't apply to HIP Tpetra: Use HIPSpace for HIPWrapperNode ...
…s:develop' (16c177b). * trilinos-develop: (71 commits) Tpetra: Remove some output from the Bug7758 test MueLu Stratimikos adapter: Enable half precision for factory-style PLs Tpetra: remove some deprecated usage ROL: implement the apply function for Thyra Vector Piro: changes to ROL adapters comply with ROL changes Piro: bug-fix in Piro::NOX_Solver Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280). Ifpack2: cleaning up unused variables in tests. Ctest: Adding Amesos2/Belos tests Ctest: Stuff failing on ride that worked on ascicgpu Ctest: Enabling non-UVM Ifpack2 tests Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp. Disable support for Makefile.export.* files (trilinos#8498) Tpetra: remove unused variable (copied too many times when breaking up a function) ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376) Ifpack2: adding missing logic for new tests. Belos: writing tests for 'long double' and 'float128' ScalarType. STK: Snapshot 06-11-21 17:50 Tpetra: remove comments that don't apply to HIP Tpetra: Use HIPSpace for HIPWrapperNode ...
I just sent out the final set of emails on this topic to the Trilinos developers and users list including the one shown below. From: Bartlett, Roscoe A Hello Trilinos users, Again, if you are not using the installed Makefile.export.Trilinos or the package-level Makefile.export. files, then please ignore. After some delays, the commit that removed support for the installed Makefile.export.* files was merged to Trilinos ‘develop’ last Friday, June 18. It has yet to be merged to the Trilinos ‘master’ branch. (Looks the ‘develop’ branch has not been merged to the ‘master’ branch in about a month.) If you have any questions, please let me know, or better yet, please comment in:
Otherwise, no more emails will be sent out on this topic. Thanks, -Ross |
My meeting with Scott Collis got pushed back from today 6/22/2021 to 7/9/2021. Therefore, I am not going to hold up this Issue anymore. I will go ahead and put this issue in review and mark it off #367. I fully expect we will get some pushback but we will deal with that later. |
…develop' (51336fe). * potential-trilinos-develop: (57 commits) Geminga: Another attempt to get valgrind suppressions working STK: Snapshot 03-12-21 10:28 MiniEM: Enable reuse, test it Remove older and more complex buildAgainstTrilinos example (trilinos#8498) Update to point to demos/simpleBuildAgainstTrilinos (trilinos#8498) Add explicit COMPONENTS (trilinos#8498) Simpler one-directory build example using Trilinos (trilinos#8498) Intrepid2: UVM-free MonolothicExecutable Tests (trilinos#8852) Link to local INSTALL.rst on same branch (trilinos#8489) Update INSTALL.rst with link to demos/buildAgainstTrilinos (trilinos#8498) Eliminate duplication in tests and set PROCESSORS property (trilinos#8498) Modernize for newer CMake and fix compile error (trilinos#8498) Piro: add 'Optimizer Iteration Number' to Piro_ThyraProductME Tpetra: remove UVM dependence from test (trilinos#8830) tpetra: trilinos#8794 trilinos#8804 test to pick threshold timed out in PR testing. Lowering the upper bound of testing to fit run into PR testing time. Threshold is close to 400, so lowering upper bound of testing should be OK. Correct gcc module loaded for tlcc2 builds MueLu: Add phase2a agg factor to param list for hybrid aggregation Piro: move the Enable Explicit Matrix Transpose option to the app parameter list Piro: print response even for iteration 0 std: -> std:: ...
…develop' (4d10f3a). * trilinos/develop: tpetra: adding syncs of import buffer before unpacking trilinos#9116 Make enable of Fortran optional and note about only needing C++ (trilinos#8498) Eliminate warnings when using BUILD_SHARED_LIBS=ON (trilinos#8498) Add missing -D to cmake line (trilinos#8498) add missing copyright statements Added missing headers to CMakeList.txt. Added summarize function to Reduced_Objective_SimOpt. Removed white space in Reduced_Constraint_SimOpt. Replaced 'and' with && and 'or' with || for MSVC compatibility. Set test only to build when ROL_ParameterList=simple. Imported streaming operator for displaying vector Added <numeric> header. Disabled use of fenv.h and feenableexcept() in tests and examples. Moved new native ROL::ParameterList to src/compatibility/simple/parameterlist and added CMake config options. Added get<T> and isSublist methods to class. Added ROL::getArrayFromParameterString free function to follow Teuchos design. Updated parameterlist to use new features. test/algorithm/TypeB/test_01.cpp can now be compiled and runs successfully with the new native list Missed one UpdateType. A few typo fixes. Added minimal ROL-native implementation of parameter list Update Version-2.0.md Fixed typo in Version 1.0 solver.
…develop' (7591b32). * trilinos/develop: (77 commits) zoltan2: fix memory leak when sizeof(SCOTCH_Num) == sizeof(lno_t) trilinos#9312 Tpetra: Remove some output from the Bug7758 test MueLu Stratimikos adapter: Enable half precision for factory-style PLs Tpetra: remove some deprecated usage Fixed some deprecated code MueLu Thyra adapter: Allow construction of half precision operator ROL: implement the apply function for Thyra Vector Piro: changes to ROL adapters comply with ROL changes Piro: bug-fix in Piro::NOX_Solver MueLu: Print Scalar in MG Summary for high and extreme verbosity Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280). Ifpack2: cleaning up unused variables in tests. Ctest: Adding Amesos2/Belos tests Ctest: Stuff failing on ride that worked on ascicgpu Ctest: Enabling non-UVM Ifpack2 tests Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp. Disable support for Makefile.export.* files (trilinos#8498) Tpetra: remove unused variable (copied too many times when breaking up a function) ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376) Ifpack2: adding missing logic for new tests. ...
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. |
FYI: The upgraded example demos/simpleBuildAgainstTrilinos has been under automated PR testing for some time now as of the merge of #10813. |
…BITSPub/TriBITS#299) Support for Makefile.export.* files was removed from TriBITS and snaphsotted into Trilinos a long time ago. This support was removed in the Trilinos 14.0 release. There is no reason to keep this cache variable anymore. It just clutters up the base CMakeLists.txt file.
…BITSPub/TriBITS#299) Support for Makefile.export.* files was removed from TriBITS and snaphsotted into Trilinos a long time ago. This support was removed in the Trilinos 14.0 release. There is no reason to keep this cache variable anymore. It just clutters up the base CMakeLists.txt file.
…BITSPub/TriBITS#299) Support for Makefile.export.* files was removed from TriBITS and snaphsotted into Trilinos a long time ago. This support was removed in the Trilinos 14.0 release. There is no reason to keep this cache variable anymore. It just clutters up the base CMakeLists.txt file.
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. |
This issue was closed due to inactivity for 395 days. |
CC: @trilinos/framework, @trilinos/trilinos-product-owners
Blocked By: #8401
As part of the imminent TriBITS refactoring described in TriBITSPub/TriBITS#299 to use modern CMake target-based features will that will be enabled by the upgrade of the minimum required CMake (see #8401) be that the current implementation for generating export makefiles (i.e.
Makefile.export.*
files) will be broken and it may be difficult to bring it back.We discussed this topic and the topic of dropping support for
Makefile.export.*
files at the Trilinos Product Leaders Meeting on 12/16/2020. The action items that came out of that were:Trilinos/demos/
that usesfind_package(Trilinos)
and uses some functionality in Trilinos ... See demos/simpleBuildAgainstTrilinosMakefile.export.Trilinos
files. (I.e., either switch to CMake or manually get the list of libraries you need such as withCMAKE_EXPORT_COMPILE_COMMANDS
) ... Plan is for customers to use CMake or manually maintain their link lines (like Sierra does)Makefile.export.Trilinos
and get feedback from internal and external customers ... Sent out emails on 5/19/2021 stating support will be dropped on 6/10/2021Makefile.export.Trilinos
on 6/10/2021.Makefile.export.Trilinos
from TriBITS and Trilinos 'develop' on 6/10/2021 ... See PR Disable support for Makefile.export.* files (#8498) #9284Makefile.export.*
files.Makefile.export.Trilinos
(meeting set for 6/22/2021... pushed back till 7/9/2021).The text was updated successfully, but these errors were encountered: