Dropping support for Makefile.export.* files with TriBITS/Trilinos refactoring to support modern CMake features #8498

bartlettroscoe · 2020-12-17T23:48:30Z

CC: @trilinos/framework, @trilinos/trilinos-product-owners

Blocked By: #8401

As part of the imminent TriBITS refactoring described in TriBITSPub/TriBITS#299 to use modern CMake target-based features will that will be enabled by the upgrade of the minimum required CMake (see #8401) be that the current implementation for generating export makefiles (i.e. Makefile.export.* files) will be broken and it may be difficult to bring it back.

We discussed this topic and the topic of dropping support for Makefile.export.* files at the Trilinos Product Leaders Meeting on 12/16/2020. The action items that came out of that were:

Add an example raw CMake project in Trilinos/demos/ that uses find_package(Trilinos) and uses some functionality in Trilinos ... See demos/simpleBuildAgainstTrilinos
Create a plan for customers to transition to no Makefile.export.Trilinos files. (I.e., either switch to CMake or manually get the list of libraries you need such as with CMAKE_EXPORT_COMPILE_COMMANDS) ... Plan is for customers to use CMake or manually maintain their link lines (like Sierra does)
Craft and send out an email to various mail lists announcing dropping support for Makefile.export.Trilinos and get feedback from internal and external customers ... Sent out emails on 5/19/2021 stating support will be dropped on 6/10/2021
Send out reminder email about dropping support for Makefile.export.Trilinos on 6/10/2021.
Update documentation on trilinos.github.io related to building against Trilinos (update Find_Trilinos.txt and remove Export_Makefile.txt) ... See PR Dropping support for Makefile.export.* files and update find_package(Trilinos) doc some (trilinos/Trilinos#8498) trilinos.github.io#49 ...
Drop support for Makefile.export.Trilinos from TriBITS and Trilinos 'develop' on 6/10/2021 ... See PR Disable support for Makefile.export.* files (#8498) #9284
Send out one list set of emails to various mail lists announcing that Trilinos 'develop' (as of the merge of PR Disable support for Makefile.export.* files (#8498) #9284) no longer supports Makefile.export.* files.
Talk with Scott Collis about dropping support for Makefile.export.Trilinos (~~meeting set for 6/22/2021~~ ... pushed back till 7/9/2021).

The text was updated successfully, but these errors were encountered:

mathstuf · 2020-12-17T23:57:28Z

Create a plan for customers to transition to no Makefile.export.Trilinos files. (I.e., either switch to CMake or manually get the list of libraries you need such as with CMAKE_EXPORT_COMPILE_COMMANDS).

Making this way more general could help: https://gitlab.kitware.com/paraview/paraview/-/blob/master/Clients/CommandLineExecutables/paraview-config.in. That is heavily ParaView-specific, but is an outline of what would be needed for something more generally.

csiefer2 · 2021-01-06T16:35:56Z

Aw, man. Those things are useful.

bartlettroscoe · 2021-01-06T17:14:07Z

Aw, man. Those things are useful.

@csiefer2, the goal would be to move customers to use CMake for their projects using Trilinos.

csiefer2 · 2021-01-07T03:15:31Z

Guess that just means I need to learn how to write cmake from scratch for little toy codes that use Trilinos...

Do we have any documentation for that?

rppawlo · 2021-01-07T13:25:38Z

Do we have any documentation for that?

Before these changes are pushed into Trilinos, we will have instructions and an example in Trilinos (probably in the demos directory). It's only a few lines of code to pull trilinos into a new cmake app.

bartlettroscoe · 2021-01-07T16:24:33Z

Do we have any documentation for that?

@csiefer2, we will. See above.

csiefer2 · 2021-01-12T20:56:42Z

@csiefer2, we will. See above.

Missed that! Cool! Thanks!

bartlettroscoe · 2021-03-08T20:15:41Z

Related to:

SEPW-213
SEPW-214

bartlettroscoe · 2021-03-09T21:59:52Z

Looks like there is some urgency for at least and example using find_pakage(Trilinos) as per #8857. I can't believe there is no documentation or even an hint in Trilinos about how to do this. (In my defense, I did not write any of the CMake code in TriBITS or Trilinos to support TrilinosConfig.cmake. But I will have to rewrite this as part of TriBITSPub/TriBITS#299.)

bartlettroscoe · 2021-03-09T22:21:24Z

CC: @rppawlo, @jwillenbring

Turns out an example of how to build against Trilinos using CMake already exists under demos/buildAgainstTrilinos. I have no idea if that still works or not. I did not even know that this example even existed!

I can test and update this example to make sure it works but then we need to protect this in PR testing.

@trilinos/framework, could you consider setting up the PR builds to do an install of Trilinos and then build and test this example project? We need to ensure that example always works and it will also do some level of installation testing.

This now builds without errors with Clang 10.0. (There was a build error before this update.) * Require CMake 3.17.1 which is the same minimum now required by Trilinos * Updated the documentation to use Markdown and use raw CMake and no do-cmake script * Deleted unneccasary do-cmake script * Deleted usage of a 'Trilinos_PREFIX' var and just use built-in CMake var CMAKE_PREFIX_PATH directly as documented in CMake documentation for 'find_package()' * Turn off warning from Kokkos about not suupporting C++ extensions * Fix build error with source code

…8498) If one is going to demonstrate how to use CTest one should also show good software engineering practicies like minimizing duplication. I also set the PROCESSORS property so that ctest -j<N>.

This now builds without errors with Clang 10.0. * Require CMake 3.17.1 which is the same minimum now required by Trilinos * Updated the documentation to use Markdown and use raw CMake and no do-cmake script * Deleted unneccasary do-cmake script * Deleted usage of a 'Trilinos_PREFIX' var and just use built-in CMake var CMAKE_PREFIX_PATH directly as documented in CMake documentation for 'find_package()' * Turned off warning from Kokkos about not suupporting C++ extensions * Fixed build error with the source code usage of Teuchos

…8498) If one is going to demonstrate how to use CTest one should also show good software engineering practicies like minimizing duplication. I also set the PROCESSORS property so that ctest -j<N>.

…8498) I removed the author and just gave the framework team email address for a contact.

…linos (trilinos#8498)

…inos#8498)

…linos (trilinos#8498)

…inos#8498)

bartlettroscoe · 2021-06-07T22:04:43Z

Looks good! Nice catch on the documentation!

I merged trilinos/trilinos.github.io#49 and now the page:

https://trilinos.github.io/documentation.html

looks to be updated including the link there to the updated text file:

https://trilinos.github.io/pdfs/Finding_Trilinos.txt

Last step is to merge an updated snapshot of TriBITS that removes support for . Makefile.export.* files on Thursday, June 10 :-)

Disabling support for Makefile.export.* files in Trilinos while TriBITS is refactored in TriBITSPub/TriBITS#299 that will remove support for this permanently.

bartlettroscoe · 2021-06-14T22:39:29Z

PR #9284 removes support for Makefile.export.* files from Trilinos. Ripping out support for Makefile.export.* in TriBITS will actually break a lot of tests because of the dependence of the TribitsExampleProject WrapExternal package that uses a generated Makefile.export.* file to glue things together. I will need to refactor that exact to use either CMake or just a raw link line before I rip out support for Makefile.export.*. By removing support from Trilinos we can deal with any blow back that that may be coming. (who were not on the email lists or were on the emails lists and just did not read the emails).

…kefile-export-files Automatically Merged using Trilinos Pull Request AutoTester PR Title: Disable support for Makefile.export.* files (#8498) PR Author: bartlettroscoe

bartlettroscoe · 2021-06-18T14:48:48Z

With the merge of PR #9284 just now, Trilinos 'develop' no longer supports the installation of Makefile.export.* files. I will send out one last set of emails to the various email lists announcing this.

…s:develop' (16c177b). * trilinos-develop: (71 commits) Tpetra: Remove some output from the Bug7758 test MueLu Stratimikos adapter: Enable half precision for factory-style PLs Tpetra: remove some deprecated usage ROL: implement the apply function for Thyra Vector Piro: changes to ROL adapters comply with ROL changes Piro: bug-fix in Piro::NOX_Solver Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280). Ifpack2: cleaning up unused variables in tests. Ctest: Adding Amesos2/Belos tests Ctest: Stuff failing on ride that worked on ascicgpu Ctest: Enabling non-UVM Ifpack2 tests Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp. Disable support for Makefile.export.* files (trilinos#8498) Tpetra: remove unused variable (copied too many times when breaking up a function) ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376) Ifpack2: adding missing logic for new tests. Belos: writing tests for 'long double' and 'float128' ScalarType. STK: Snapshot 06-11-21 17:50 Tpetra: remove comments that don't apply to HIP Tpetra: Use HIPSpace for HIPWrapperNode ...

bartlettroscoe · 2021-06-21T21:35:32Z

I just sent out the final set of emails on this topic to the Trilinos developers and users list including the one shown below.

From: Bartlett, Roscoe A
Sent: Monday, June 21, 2021 5:33 PM
To: trilinos-announce@trilinos.org; trilinos-users@trilinos.org
Subject: RE: Trilinos dropping support for Makefile.export.* files

Hello Trilinos users,

Again, if you are not using the installed Makefile.export.Trilinos or the package-level Makefile.export. files, then please ignore.

After some delays, the commit that removed support for the installed Makefile.export.* files was merged to Trilinos ‘develop’ last Friday, June 18. It has yet to be merged to the Trilinos ‘master’ branch. (Looks the ‘develop’ branch has not been merged to the ‘master’ branch in about a month.)

If you have any questions, please let me know, or better yet, please comment in:

https://github.com/trilinos/Trilinos/issues/8498

Otherwise, no more emails will be sent out on this topic.

Thanks,

-Ross

bartlettroscoe · 2021-06-22T16:25:39Z

My meeting with Scott Collis got pushed back from today 6/22/2021 to 7/9/2021. Therefore, I am not going to hold up this Issue anymore. I will go ahead and put this issue in review and mark it off #367. I fully expect we will get some pushback but we will deal with that later.

…develop' (51336fe). * potential-trilinos-develop: (57 commits) Geminga: Another attempt to get valgrind suppressions working STK: Snapshot 03-12-21 10:28 MiniEM: Enable reuse, test it Remove older and more complex buildAgainstTrilinos example (trilinos#8498) Update to point to demos/simpleBuildAgainstTrilinos (trilinos#8498) Add explicit COMPONENTS (trilinos#8498) Simpler one-directory build example using Trilinos (trilinos#8498) Intrepid2: UVM-free MonolothicExecutable Tests (trilinos#8852) Link to local INSTALL.rst on same branch (trilinos#8489) Update INSTALL.rst with link to demos/buildAgainstTrilinos (trilinos#8498) Eliminate duplication in tests and set PROCESSORS property (trilinos#8498) Modernize for newer CMake and fix compile error (trilinos#8498) Piro: add 'Optimizer Iteration Number' to Piro_ThyraProductME Tpetra: remove UVM dependence from test (trilinos#8830) tpetra: trilinos#8794 trilinos#8804 test to pick threshold timed out in PR testing. Lowering the upper bound of testing to fit run into PR testing time. Threshold is close to 400, so lowering upper bound of testing should be OK. Correct gcc module loaded for tlcc2 builds MueLu: Add phase2a agg factor to param list for hybrid aggregation Piro: move the Enable Explicit Matrix Transpose option to the app parameter list Piro: print response even for iteration 0 std: -> std:: ...

…develop' (4d10f3a). * trilinos/develop: tpetra: adding syncs of import buffer before unpacking trilinos#9116 Make enable of Fortran optional and note about only needing C++ (trilinos#8498) Eliminate warnings when using BUILD_SHARED_LIBS=ON (trilinos#8498) Add missing -D to cmake line (trilinos#8498) add missing copyright statements Added missing headers to CMakeList.txt. Added summarize function to Reduced_Objective_SimOpt. Removed white space in Reduced_Constraint_SimOpt. Replaced 'and' with && and 'or' with || for MSVC compatibility. Set test only to build when ROL_ParameterList=simple. Imported streaming operator for displaying vector Added <numeric> header. Disabled use of fenv.h and feenableexcept() in tests and examples. Moved new native ROL::ParameterList to src/compatibility/simple/parameterlist and added CMake config options. Added get<T> and isSublist methods to class. Added ROL::getArrayFromParameterString free function to follow Teuchos design. Updated parameterlist to use new features. test/algorithm/TypeB/test_01.cpp can now be compiled and runs successfully with the new native list Missed one UpdateType. A few typo fixes. Added minimal ROL-native implementation of parameter list Update Version-2.0.md Fixed typo in Version 1.0 solver.

…develop' (7591b32). * trilinos/develop: (77 commits) zoltan2: fix memory leak when sizeof(SCOTCH_Num) == sizeof(lno_t) trilinos#9312 Tpetra: Remove some output from the Bug7758 test MueLu Stratimikos adapter: Enable half precision for factory-style PLs Tpetra: remove some deprecated usage Fixed some deprecated code MueLu Thyra adapter: Allow construction of half precision operator ROL: implement the apply function for Thyra Vector Piro: changes to ROL adapters comply with ROL changes Piro: bug-fix in Piro::NOX_Solver MueLu: Print Scalar in MG Summary for high and extreme verbosity Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280). Ifpack2: cleaning up unused variables in tests. Ctest: Adding Amesos2/Belos tests Ctest: Stuff failing on ride that worked on ascicgpu Ctest: Enabling non-UVM Ifpack2 tests Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp. Disable support for Makefile.export.* files (trilinos#8498) Tpetra: remove unused variable (copied too many times when breaking up a function) ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376) Ifpack2: adding missing logic for new tests. ...

github-actions · 2022-06-25T12:28:29Z

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

bartlettroscoe · 2022-09-30T00:41:43Z

https://github.com/orgs/trilinos/teams/framework, could you consider setting up the PR builds to do an install of Trilinos and then build and test this example project? We need to ensure that example always works and it will also do some level of installation testing.

FYI: The upgraded example demos/simpleBuildAgainstTrilinos has been under automated PR testing for some time now as of the merge of #10813.

…BITSPub/TriBITS#299) Support for Makefile.export.* files was removed from TriBITS and snaphsotted into Trilinos a long time ago. This support was removed in the Trilinos 14.0 release. There is no reason to keep this cache variable anymore. It just clutters up the base CMakeLists.txt file.

github-actions · 2023-09-30T12:23:47Z

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions · 2023-11-01T12:26:38Z

This issue was closed due to inactivity for 395 days.

bartlettroscoe added type: enhancement Issue is an enhancement, not a bug impacting: documentation The issue is primarily about documentation vs. a problem with the build or tests PA: Framework Issues that fall under the Trilinos Framework Product Area labels Dec 17, 2020

bartlettroscoe added this to Backlog in Trilinos Framework via automation Dec 17, 2020

bartlettroscoe mentioned this issue Dec 17, 2020

Move to modern CMake target-based propagation of build information TriBITSPub/TriBITS#299

Closed

10 tasks

bartlettroscoe mentioned this issue Dec 18, 2020

Framework: Increase the minimum CMake version requirement #8401

Closed

3 tasks

bartlettroscoe added the TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework label Feb 11, 2021

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

Update INSTALL.rst with link to demos/buildAgainstTrilinos (trilinos#…

e3e6b09

…8498) I removed the author and just gave the framework team email address for a contact.

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Update INSTALL.rst with link to demos/buildAgainstTri…

d603fc5

…linos (trilinos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Update INSTALL.rst with link to demos/buildAgainstTri…

ddfc59a

…linos (trilinos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Modernize for newer CMake and fix compile error (tril…

00c73d8

…inos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Modernize for newer CMake and fix compile error (tril…

1b79564

…inos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Modernize for newer CMake and fix compile error (tril…

65e6358

…inos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Update INSTALL.rst with link to demos/buildAgainstTri…

e04bd2b

…linos (trilinos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Modernize for newer CMake and fix compile error (tril…

fb40fcf

…inos#8498)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Mar 10, 2021

SQUASH AGAINST: Modernize for newer CMake and fix compile error (tril…

5bc69e4

…inos#8498)

bartlettroscoe mentioned this issue Jun 14, 2021

Disable support for Makefile.export.* files (#8498) #9284

Merged

bartlettroscoe moved this from In Progress to In Review in Trilinos TriBITS Refactor Jun 22, 2021

jwillenbring removed this from Backlog in Trilinos Framework Aug 20, 2021

bartlettroscoe moved this from In Review to Done in Trilinos TriBITS Refactor Sep 9, 2021

bartlettroscoe mentioned this issue Sep 14, 2021

Remove support for export makefiles (#299) TriBITSPub/TriBITS#420

Merged

esys-escript mentioned this issue Feb 7, 2022

Trilinos Makefile.export LutzGross/esys-escript.github.io#69

Open

github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jun 25, 2022

bartlettroscoe removed the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jun 27, 2022

github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Sep 30, 2023

github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Nov 1, 2023

github-actions bot closed this as completed Nov 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dropping support for Makefile.export.* files with TriBITS/Trilinos refactoring to support modern CMake features #8498

Dropping support for Makefile.export.* files with TriBITS/Trilinos refactoring to support modern CMake features #8498

bartlettroscoe commented Dec 17, 2020 •

edited

Loading

mathstuf commented Dec 17, 2020

csiefer2 commented Jan 6, 2021

bartlettroscoe commented Jan 6, 2021

csiefer2 commented Jan 7, 2021

rppawlo commented Jan 7, 2021

bartlettroscoe commented Jan 7, 2021

csiefer2 commented Jan 12, 2021

bartlettroscoe commented Mar 8, 2021 •

edited

Loading

bartlettroscoe commented Mar 9, 2021

bartlettroscoe commented Mar 9, 2021

bartlettroscoe commented Jun 7, 2021

bartlettroscoe commented Jun 14, 2021

bartlettroscoe commented Jun 18, 2021

bartlettroscoe commented Jun 21, 2021

bartlettroscoe commented Jun 22, 2021

github-actions bot commented Jun 25, 2022

bartlettroscoe commented Sep 30, 2022

github-actions bot commented Sep 30, 2023

github-actions bot commented Nov 1, 2023

Dropping support for Makefile.export.* files with TriBITS/Trilinos refactoring to support modern CMake features #8498

Dropping support for Makefile.export.* files with TriBITS/Trilinos refactoring to support modern CMake features #8498

Comments

bartlettroscoe commented Dec 17, 2020 • edited Loading

mathstuf commented Dec 17, 2020

csiefer2 commented Jan 6, 2021

bartlettroscoe commented Jan 6, 2021

csiefer2 commented Jan 7, 2021

rppawlo commented Jan 7, 2021

bartlettroscoe commented Jan 7, 2021

csiefer2 commented Jan 12, 2021

bartlettroscoe commented Mar 8, 2021 • edited Loading

bartlettroscoe commented Mar 9, 2021

bartlettroscoe commented Mar 9, 2021

bartlettroscoe commented Jun 7, 2021

bartlettroscoe commented Jun 14, 2021

bartlettroscoe commented Jun 18, 2021

bartlettroscoe commented Jun 21, 2021

bartlettroscoe commented Jun 22, 2021

github-actions bot commented Jun 25, 2022

bartlettroscoe commented Sep 30, 2022

github-actions bot commented Sep 30, 2023

github-actions bot commented Nov 1, 2023

bartlettroscoe commented Dec 17, 2020 •

edited

Loading

bartlettroscoe commented Mar 8, 2021 •

edited

Loading