Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate max_allowed_packet on the client side #84

Merged
merged 4 commits into from
Jun 7, 2023
Merged

validate max_allowed_packet on the client side #84

merged 4 commits into from
Jun 7, 2023

Commits on Jun 7, 2023

  1. Perform client-side checks against max_allowed_packet 

    Sending an over-limit packet will cause the server to drop the
connection; by enforcing the limit on the client, we can fail in a way
that keeps the connection usable.

Co-authored-by: Kamil Gwóźdź <kamil-gwozdz@github.com>
    @matthewd @kamil-gwozdz
    matthewd and kamil-gwozdz committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    3d501bd View commit details
    Browse the repository at this point in the history

  2. Despite the name, we aren't actually allowed to send a max-sized packet

    @matthewd
    matthewd committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    79ea406 View commit details
    Browse the repository at this point in the history

  3. Avoid reading uninitialized memory during test 

    We don't really care what's in there, but this is more hygienic, and
will likely keep Valgrind happier.
    @matthewd
    matthewd committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    bbfb0ec View commit details
    Browse the repository at this point in the history

  4. Pass max_allowed_packet through the ruby library 

    Co-authored-by: Kamil Gwóźdź <kamil-gwozdz@github.com>
    @matthewd @kamil-gwozdz
    matthewd and kamil-gwozdz committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    176b9b6 View commit details
    Browse the repository at this point in the history