Dam variants #31
Merged
Dam variants #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlevy
previously approved these changes
Jul 11, 2018
gdbrown
requested changes
Jul 11, 2018
There was a problem hiding this comment.
@rsumilang since the asset id map returned is singular you must provide "quality" and "version" as a single string value. i would also put a pattern on that so we can ensure consistency. either something like \w+ or just format of slug.
gdbrown
approved these changes
Jul 11, 2018
gdbrown
pushed a commit
that referenced
this pull request
Jul 15, 2018
* Adding qualities and versions fields to get uploads url request. * Updating changelog * Updating changelog * Updating quality and version fields format * don't allow slashes in version or quality * 0.6.1 * 0.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding qualities and versions string field.