-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalize page permission key conf #352
Merged
ebyhr
merged 1 commit into
trinodb:main
from
Chaho12:feature/jyoo/set_page_permission_key_uppercase
May 31, 2024
Merged
Capitalize page permission key conf #352
ebyhr
merged 1 commit into
trinodb:main
from
Chaho12:feature/jyoo/set_page_permission_key_uppercase
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check CI failure:
|
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 22, 2024 08:50
4616df0
to
ca07cfd
Compare
ebyhr
reviewed
May 22, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 23, 2024 01:34
ca07cfd
to
8ebeb13
Compare
Please fix CI failure:
|
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 23, 2024 05:04
8ebeb13
to
ee2212b
Compare
ytwp
approved these changes
May 24, 2024
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
2 times, most recently
from
May 24, 2024 05:45
642b6ce
to
fa7204f
Compare
ebyhr
reviewed
May 24, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
May 24, 2024
gateway-ha/src/test/java/io/trino/gateway/ha/security/TestLbAuthenticator.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 31, 2024 05:10
fa7204f
to
87a8302
Compare
Please fix CI failure:
|
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 31, 2024 05:27
87a8302
to
1d94edb
Compare
Chaho12
commented
May 31, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
3 times, most recently
from
May 31, 2024 05:52
f02574b
to
acd34fb
Compare
ebyhr
reviewed
May 31, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 31, 2024 05:54
acd34fb
to
4183359
Compare
ebyhr
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 31, 2024 11:58
4183359
to
bbcfd6f
Compare
Chaho12
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 31, 2024 12:06
bbcfd6f
to
a0e6bb4
Compare
ebyhr
force-pushed
the
feature/jyoo/set_page_permission_key_uppercase
branch
from
May 31, 2024 12:09
a0e6bb4
to
c38e90d
Compare
ebyhr
approved these changes
May 31, 2024
I pushed small changes because the indentation was wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since both roles in web & security context are in upper-case, page permission should also be in upper case to match with roles.
Without this patch, user has to set upper-case key's in yaml in their yaml file as below, which is awkward as all other auth related confs are in lower-case.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
*
Test