Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin #23

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update plugin #23

merged 1 commit into from
Jan 30, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jan 30, 2024

Changes:

  • use latest Takari parent POM, update takari test tooling
  • compile against latest Maven (to pick up deprecations), keep prerequisite
  • update tooling
  • update p-u to latest Maven 3.x (keep in [3,4) range)
  • aling maven core and maven artifact, make it provided as it is
  • mark mojos thread safe (as they seems as they are, please tell if I missed something)
  • update lifecycle, do NOT use Maven2 plugin ever ever again
  • use wrapper and do not rely on 3rd party provided Maven: this way you are fully in control

@wendigo
Copy link
Contributor

wendigo commented Jan 30, 2024

@cstamas please update first commit message. I'll merge this PR after that.

Changes:
* use latest Takari parent POM, update takari test tooling
* compile against latest Maven (to pick up deprecations), keep prerequisite
* update tooling
* update p-u to latest Maven 3.x (keep in [3,4) range)
* aling maven core and maven artifact, make it provided as it is
* mark mojos thread safe (as they seems as they are, please tell if I missed something)
* update lifecycle, do NOT use Maven2 plugin ever ever again
* use wrapper and do not rely on 3rd party provided Maven: this way you are fully in control
@cstamas
Copy link
Member Author

cstamas commented Jan 30, 2024

squashed and message updated

@cstamas
Copy link
Member Author

cstamas commented Jan 30, 2024

A release would be welcome as well...

@wendigo wendigo merged commit ebd3326 into trinodb:master Jan 30, 2024
2 checks passed
@wendigo
Copy link
Contributor

wendigo commented Jan 30, 2024

Tested locally. Seems good to go.

@cstamas cstamas deleted the update-plugin branch January 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants