Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #453

Merged
merged 3 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout the source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Install Python"
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: "3.12"
cache: "pip"
hashhar marked this conversation as resolved.
Show resolved Hide resolved
cache-dependency-path: setup.py

- name: "Install pre-commit"
run: pip install pre-commit
Expand Down Expand Up @@ -63,10 +65,12 @@ jobs:
env:
TRINO_VERSION: "${{ matrix.trino }}"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
cache: "pip"
cache-dependency-path: setup.py
- name: Install dependencies
run: |
sudo apt-get update
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ on:
workflow_dispatch:

env:
PYTHON_VERSION: "3.11"
PYTHON_VERSION: "3.12"

jobs:
release:
name: trino-python-client release
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v3
- uses: actions/setup-python@v4
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{env.PYTHON_VERSION}}

Expand Down
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
repos:
- repo: "https://github.com/PyCQA/flake8"
rev: "5.0.4"
rev: "7.0.0"
hooks:
- id: "flake8"
name: "Python: analysis"

- repo: "https://github.com/pre-commit/mirrors-mypy"
rev: "v1.0.0"
rev: "v1.8.0"
hooks:
- id: "mypy"
name: "Python: types"
additional_dependencies:
- "types-all"

- repo: https://github.com/pycqa/isort
rev: "5.12.0"
rev: "5.13.2"
hooks:
- id: isort
args: [ "--profile", "black"]

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: "v4.4.0"
rev: "v4.5.0"
hooks:
- id: check-yaml
args: [--unsafe]
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@

import os
from codecs import open
from typing import Any
from typing import Any, Dict

from setuptools import find_packages, setup

about = {} # type: dict[str, Any]
about: Dict[str, Any] = {}
here = os.path.abspath(os.path.dirname(__file__))
with open(os.path.join(here, "trino", "_version.py"), "r", "utf-8") as f:
exec(f.read(), about)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/sqlalchemy/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _assert_sqltype(this: SQLType, that: SQLType):
if isinstance(that, type):
that = that()

assert type(this) == type(that)
assert type(this) is type(that)

if isinstance(this, ARRAY):
_assert_sqltype(this.item_type, that.item_type)
Expand Down