Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paper page when used with trailing slash #76

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

electrum
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Apr 14, 2020
@mosabua
Copy link
Member

mosabua commented Apr 14, 2020

Why would the page have a trailing / in the URL? If you do that you are making the page only work correctly in the root context. Maybe better to use ./

@electrum
Copy link
Member Author

The URL can be accessed in several ways

People often type URLs manually and thus it might end in a trailing slash. If we're going to serve the page, it shouldn't be broken. (and we don't have a choice on serving it or redirecting since that's what Netlify does)

@electrum
Copy link
Member Author

Note that the entire Jekyll site is generated to be in the root context. I don't see a problem with that, since the site has a singular purpose. This is different from the documentation, which is intentionally generated to be relative, as it might be used in different contexts.

@electrum electrum requested review from martint and dain April 14, 2020 19:13
@electrum electrum merged commit 80fd63f into trinodb:master Apr 14, 2020
@electrum electrum deleted the paper branch April 14, 2020 19:24
@mosabua
Copy link
Member

mosabua commented Apr 14, 2020

I would use ./ as a fix then ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants