Minor fixes: toString, and mvnd version picking in run-launcher #11568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
|
CI #11275 |
|
PTAL |
losipiuk
reviewed
Mar 21, 2022
| @@ -5,7 +5,8 @@ target="${BASH_SOURCE%/*/*}/target" | |||
| if command -v mvnd >/dev/null; then | |||
| # Using mvnd here can save more than 2 seconds compared to ./mvnw startup cost. This is especially important | |||
| # when invoking inspection commands like --help, env list, etc. | |||
| trino_version=$(mvnd -B help:evaluate -Dexpression=pom.version -q -DforceStdout --raw-streams) | |||
There was a problem hiding this comment.
typo in commit message (whren)
There was a problem hiding this comment.
thanks, fixed.
also added a link to apache/maven-mvnd#604
losipiuk
approved these changes
Mar 21, 2022
Log purging message currently goes to stdout, see apache/maven-mvnd#604
findepi
force-pushed
the
findepi/implement-assignment-tostring-421466
branch
from
eceb3e7
to
e82c343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.