Use gather over partitioned exchange for small join build side #12257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-stec
force-pushed
the
ls/016-use-gather-for-small-build
branch
5 times, most recently
from
59096f2
to
9f5b89a
Compare
sopel39
approved these changes
May 16, 2022
sopel39
reviewed
May 16, 2022
core/trino-main/src/main/java/io/trino/sql/planner/PlanOptimizers.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
May 16, 2022
...ain/src/main/java/io/trino/sql/planner/iterative/rule/UseNonPartitionedJoinLookupSource.java
Outdated
Show resolved
Hide resolved
...ain/src/main/java/io/trino/sql/planner/iterative/rule/UseNonPartitionedJoinLookupSource.java
Outdated
Show resolved
Hide resolved
lukasz-stec
force-pushed
the
ls/016-use-gather-for-small-build
branch
from
9f5b89a
to
bd27013
Compare
|
javadoc + comment updated |
core/trino-main/src/main/java/io/trino/sql/planner/OptimizerConfig.java
Outdated
Show resolved
Hide resolved
...ain/src/main/java/io/trino/sql/planner/iterative/rule/UseNonPartitionedJoinLookupSource.java
Show resolved
Hide resolved
...src/test/java/io/trino/sql/planner/iterative/rule/TestUseNonPartitionedJoinLookupSource.java
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestAddExchangesPlans.java
Outdated
Show resolved
Hide resolved
lukasz-stec
force-pushed
the
ls/016-use-gather-for-small-build
branch
from
bd27013
to
a1544f7
Compare
lukasz-stec
commented
May 17, 2022
...ain/src/main/java/io/trino/sql/planner/iterative/rule/UseNonPartitionedJoinLookupSource.java
Show resolved
Hide resolved
raunaqmorarka
approved these changes
May 17, 2022
sopel39
approved these changes
May 17, 2022
| @@ -1198,6 +1205,17 @@ private static Integer validateIntegerValue(Object value, String property, int l | |||
| return intValue; | |||
| } | |||
|
|
|||
| private static void validateNonNegativeLongValue(Long value, String property) | |||
| { | |||
| if (value == null) { | |||
There was a problem hiding this comment.
I don't think you can set null session property
There was a problem hiding this comment.
I think you're right, i dropped the null check. Interestingly there are a lot of null checks in this class in other places.
|
let's also document the config in |
lukasz-stec
force-pushed
the
ls/016-use-gather-for-small-build
branch
from
a1544f7
to
ffabb9d
Compare
lukasz-stec
commented
May 17, 2022
There was a problem hiding this comment.
null check dropped.
Added doc to properties-optimizer.rst
@mosabua @raunaqmorarka @sopel39 PTAL
| @@ -1198,6 +1205,17 @@ private static Integer validateIntegerValue(Object value, String property, int l | |||
| return intValue; | |||
| } | |||
|
|
|||
| private static void validateNonNegativeLongValue(Long value, String property) | |||
| { | |||
| if (value == null) { | |||
There was a problem hiding this comment.
I think you're right, i dropped the null check. Interestingly there are a lot of null checks in this class in other places.
raunaqmorarka
approved these changes
May 18, 2022
Not partitioned lookup source has better performance than partitioned one so for small build side the overall join performance is better even if the lookup source is created using a single thread.
lukasz-stec
force-pushed
the
ls/016-use-gather-for-small-build
branch
from
ffabb9d
to
08f8059
Compare
|
documentation updated |
|
Failed due to #12413 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not partitioned lookup source has better performance
than partitioned one so for small build side the overall
join performance is better even if the lookup source is
created using a single thread.
Benchmarks
orc sf1000 part
~6% gain for tpcds, tpch no diff
use-gather-on-small-build-rule-part.pdf
improvement
core query engine, planner
Improve join performance for some subset of queries
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: