Prefer interruptible methods to joni functions #13064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test class is related to scalar functions, so it should be placed under the scalar package
arhimondr
approved these changes
Jul 1, 2022
phd3
approved these changes
Jul 4, 2022
core/trino-main/src/test/java/io/trino/sql/gen/TestExpressionCompiler.java
Outdated
Show resolved
Hide resolved
Under certain circumstances JONI regexp matching is very slow, so in this commit we use the interruptible method in the JONI regexp library so that we can interrupt long running tasks. Co-authored-by: Yingjie Luan <1275963@gmail.com>
tangjiangling
force-pushed
the
prefer-interruptible-methods-to-joni-functions
branch
from
1026df9
to
292a232
Compare
|
AC @phd3 PTAL |
|
@tangjiangling could you propose a release note for this / why do we need to exit long-running JONI functions? |
|
@colebow Updated RN, you can review it. |
findepi
reviewed
Jul 19, 2022
core/trino-main/src/main/java/io/trino/operator/scalar/JoniRegexpFunctions.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances JONI regexp matching is very slow,
so in this PR we use the interruptible method in the JONI
regexp library so that we can interrupt long running tasks.
Co-authored-by: @leetcode-1533
Description
Fix.
Core query engine.
This allows the JONI regexp functions to be interrupted, which also gives the opportunity to exit the task that has been running the JONI regexp function for a long time.
Related issues, pull requests, and links
Superceding #12479
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: