Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type mapping documentation for Oracle connector #13659

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

tlblessing
Copy link
Member

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Minor documentation improvement for Oracle connector for consistency.

How would you describe this change to a non-technical end user or system administrator?

Added some boilerplate intro text only for reading and writing data type sections. Fixed table format for less wrapping.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "No other types are supported" below each table

@tlblessing
Copy link
Member Author

Please add "No other types are supported" below each table

Done in commit bc3c7f4

Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/main/sphinx/connector/oracle.rst Outdated Show resolved Hide resolved
@tlblessing
Copy link
Member Author

@ebyhr I think this PR is ready to merge now. Thank you!

@ebyhr ebyhr merged commit 59618ec into trinodb:master Aug 18, 2022
@github-actions github-actions bot added this to the 394 milestone Aug 18, 2022
@ebyhr
Copy link
Member

ebyhr commented Aug 18, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants