Filter out values from system.metadata tables using access control #14197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huberty89
requested review from
dain,
kokosing,
ksobolew,
electrum and
raunaqmorarka
kokosing
reviewed
Sep 20, 2022
huberty89
force-pushed
the
hubert/fix-system-metadata-access
branch
from
29deef9
to
d3d89fb
Compare
|
@raunaqmorarka @ksobolew @kokosing Added tests, please take a look |
huberty89
force-pushed
the
hubert/fix-system-metadata-access
branch
from
d3d89fb
to
28a3cc6
Compare
ksobolew
approved these changes
Nov 17, 2022
raunaqmorarka
approved these changes
Nov 17, 2022
kokosing
approved these changes
Nov 17, 2022
|
@huberty89 Thanks! Merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR filter out values using configured access control from tables:
analyze_propertiescolumn_propertiesmaterialized_view_propertiesschema_propertiestable_propertiesRelated issues, pull requests, and links
Non-technical explanation
Do not leak configured catalogs names when user does not have an access to them
Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: