-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename config properties in Google Sheets #15042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? The connector properties already live in separate namespace from other connectors.
For consistency with other connectors. I suppose we use such prefixes regardless of namespace conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comment.
Consistency makes sense but personally I think moving in the less verbose direction is cleaner. I don't feel too strongly about it.
However your change matches the majority of connectors - trino-base-jdbc
is the big one which doesn't use prefixes but almost everything else does.
@@ -46,10 +46,10 @@ public void testExplicitPropertyMappings() | |||
Path credentialsFile = Files.createTempFile(null, null); | |||
|
|||
Map<String, String> properties = ImmutableMap.<String, String>builder() | |||
.put("credentials-path", credentialsFile.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a testLegacyConfigs?
0804a6d
to
2b00fa1
Compare
Description
Rename config properties in Google Sheets
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: