Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect result when add/subtract interval with timestamptz #15290

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Dec 5, 2022

Description

Fixes #15103

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Fix incorrect results when adding or subtracting `interval` from `timestamp with time zone` type. ({issue}`15103`)

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2022
@ebyhr
Copy link
Member Author

ebyhr commented Dec 5, 2022

CI hit OOM issue. #14248 #15293

@ebyhr ebyhr self-assigned this Dec 5, 2022
@ebyhr ebyhr requested review from findepi and martint December 5, 2022 08:53
@findepi
Copy link
Member

findepi commented Dec 5, 2022

ISOChronology chronology = ISOChronology.getInstanceUTC();
seems likewise affected

@findepi
Copy link
Member

findepi commented Dec 5, 2022

CI hit OOM issue. #14248 #15293

it hit trino-hive test failure too -- #13633

@ebyhr
Copy link
Member Author

ebyhr commented Dec 6, 2022

CI hit #12818

I will send another PR if date_diff function exactly has a correctness issue.

@ebyhr ebyhr merged commit e5fbc73 into trinodb:master Dec 6, 2022
@ebyhr ebyhr deleted the ebi/core-interval branch December 6, 2022 06:05
@ebyhr ebyhr mentioned this pull request Dec 6, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Different results to similar datetime handling with date_add('month', -1 vs - interval '1' month
3 participants