Add support for base64 encoded secrets in Google Sheets connector #15477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library was multiple years old with several security warnings
grantatspothero
force-pushed
the
gn/sheetsConnectorCredentialSupport
branch
from
332d541
to
e2df71a
Compare
ebyhr
reviewed
Dec 20, 2022
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsConfig.java
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestSheetsConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestSheetsConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestSheetsConfig.java
Outdated
Show resolved
Hide resolved
ebyhr
changed the title
krvikash
reviewed
Dec 21, 2022
grantatspothero
force-pushed
the
gn/sheetsConnectorCredentialSupport
branch
2 times, most recently
from
f9ec50f
to
d99ed57
Compare
ebyhr
force-pushed
the
gn/sheetsConnectorCredentialSupport
branch
from
d99ed57
to
958e279
Compare
ebyhr
approved these changes
Dec 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the google sheets connector to be configured by base64 encoded string (instead of file). Simplifies deployments of trino since you do not need to configure a file. This is similar to what is supported for the bigquery connector: https://github.com/trinodb/trino/blob/master/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/StaticCredentialsConfig.java#L27
Also updates the google sheets dependency version, the current version: https://mvnrepository.com/artifact/com.google.apis/google-api-services-sheets/v4-rev516-1.23.0 is multiple years old and has a dependency on
google-api-clientwith a security vulnerability.Additional context and related issues
N/A
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: