Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iceberg Rest Catalog: Fix bug where listing namespaces was performed but non-existing namespace was provided #19980

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

amogh-jahagirdar
Copy link
Contributor

Fix bug where listing namespaces was performed but non-existing namespace was provided. This is coming from discussion on #19818 #19818 (comment)

Description

This change fixes a bug where if an explicit namespace was provided the listTables implementation would do a full listing of the all the namespaces even if the namespace does not exist at the time.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( X) Release notes are required, with the following suggested text:

# Section
* Fix bug where listing namespaces was performed but non-existing namespace was provided.  This applies when listing tables.

Copy link

cla-bot bot commented Nov 30, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the iceberg Iceberg connector label Nov 30, 2023
@amogh-jahagirdar
Copy link
Contributor Author

I submitted my CLA yesterday, should take a few days. @findepi before we merge it would be great to get @danielcweeks input on this, want to make sure that the original implementation wasn't intentional.

Copy link

cla-bot bot commented Dec 1, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Contributor

@danielcweeks danielcweeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this issue was unintentionally introduced when adding support for listing all namespaces when the namespace was provided. Good catch.

@amogh-jahagirdar
Copy link
Contributor Author

amogh-jahagirdar commented Dec 6, 2023

Looks like an unrelated test is failing:

| 53f8cacad1c34c54a089985820c1df72 | suite-8-non-generic | singlenode-hive-acid | config-default |      {} | FAILED |  31.15m | Tests exited with code 1 |

@amogh-jahagirdar amogh-jahagirdar force-pushed the fix-namespace-bug branch 3 times, most recently from 978969d to 0175134 Compare December 18, 2023 14:34
@amogh-jahagirdar
Copy link
Contributor Author

amogh-jahagirdar commented Dec 18, 2023

Rebased:

It still looks like 2 other unrelated Hive tests are failing:

 TestHiveMerge > testMergeMultipleRowsMatchFails(0: CREATE TABLE %s (customer STRING, purchases INT, address STRING) STORED AS ORC TBLPROPERTIES ('transactional'='true')) [groups: hive_transactional] 

 TestHiveTransactionalTable > testReadFullAcidPartitioned [groups: hive_transactional] 

@findepi findepi merged commit 2be084c into trinodb:master Jan 8, 2024
43 checks passed
@github-actions github-actions bot added this to the 436 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

5 participants