Use createOrOverwrite to create transaction log files on s3 #20945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elonazoulay
reviewed
Mar 5, 2024
| outputStream.write(entryContents); | ||
| } | ||
| // write transaction log entry atomically by keeping in mind that S3 does not support creating files exclusively | ||
| fileSystem.newOutputFile(newLogEntryPath).createOrOverwrite(entryContents); |
There was a problem hiding this comment.
This no longer creates an empty file, right?
There was a problem hiding this comment.
No, the creation or overwrite (s3 does not allow exclusive file writing) should be atomic.
The concern was actually here not to have it half-baked - containing not all the bytes of the content.
elonazoulay
approved these changes
Mar 5, 2024
|
/test-with-secrets sha=e3fcd2514570cc0cc7a3ad3f1ab4b8ac216a9fc7 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8164693715 |
ebyhr
approved these changes
Mar 6, 2024
wendigo
approved these changes
Mar 6, 2024
electrum
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up work for e178494 to ensure that transaction log files are written atomically on S3 for Delta Lake in order to avoid to end up on the storage half-baked (leading to table corruption).
Additional context and related issues
#20913
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.